Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[19.07] python-dateutil: pin setuptools-scm version to 5.0.2 #16004

Merged
merged 2 commits into from Jul 3, 2021

Conversation

commodo
Copy link
Contributor

@commodo commodo commented Jun 30, 2021

Maintainer: me
Compile tested: ath79 openwrt-19.07 openwrt/openwrt@71fa524
Run tested: n/a

@jefferyto @BKPepe @DeathCamel58
Continuing from #15995

This looks like it produces a more correct output.

Signed-off-by: Alexandru Ardelean ardeleanalex@gmail.com

This reverts commit 29da5d6.

That fix doesn't work fully correct as the egg directory has version 0.0.0.

Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com>
This is known to still work with Python2.

Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com>
commodo added a commit to commodo/packages that referenced this pull request Jun 30, 2021
Following:
  openwrt#16004
  openwrt#15995
  openwrt#15988

It seems that dateutil requires setuptools-scm to be installed.
As such, this is being added as a dependency.

Also, bump setuptools-scm to version 6.0.1

Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com>
@commodo commodo changed the title Python dateutil setuptools scm [19.07] python-dateutil: pin setuptools-scm version to 5.0.2 Jul 1, 2021
@commodo
Copy link
Contributor Author

commodo commented Jul 1, 2021

Changelog v1 -> v2:

  • updated PR title to [19.07] python-dateutil: pin setuptools-scm version to 5.0.2

Copy link
Member

@jefferyto jefferyto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me - thanks!

commodo added a commit to commodo/packages that referenced this pull request Jul 2, 2021
Following:
  openwrt#16004
  openwrt#15995
  openwrt#15988

It seems that dateutil requires setuptools-scm to be installed.
As such, this is being added as a dependency.

Also, bump setuptools-scm to version 6.0.1

Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com>
commodo added a commit to commodo/packages that referenced this pull request Jul 2, 2021
Following:
  openwrt#16004
  openwrt#15995
  openwrt#15988

It seems that dateutil requires setuptools-scm to be installed.
As such, this is being added as a dependency.

Also, bump setuptools-scm to version 6.0.1

Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com>
(cherry picked from commit e202634)
@neheb neheb merged commit 5837c5a into openwrt:openwrt-19.07 Jul 3, 2021
1715173329 pushed a commit to immortalwrt/packages that referenced this pull request Jul 4, 2021
Following:
  openwrt/packages#16004
  openwrt/packages#15995
  openwrt/packages#15988

It seems that dateutil requires setuptools-scm to be installed.
As such, this is being added as a dependency.

Also, bump setuptools-scm to version 6.0.1

Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com>
Signed-off-by: Tianling Shen <cnsztl@immortalwrt.org>
@commodo commodo deleted the python-dateutil-setuptools-scm branch July 5, 2021 08:01
breakings pushed a commit to breakings/packages that referenced this pull request Mar 5, 2022
Following:
  openwrt/packages#16004
  openwrt/packages#15995
  openwrt/packages#15988

It seems that dateutil requires setuptools-scm to be installed.
As such, this is being added as a dependency.

Also, bump setuptools-scm to version 6.0.1

Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com>
(cherry picked from commit e202634)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants