Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stubby: Add multi WAN support for procd trigger #16285

Merged
merged 1 commit into from Aug 7, 2021

Conversation

jamesmacwhite
Copy link
Contributor

@jamesmacwhite jamesmacwhite commented Aug 3, 2021

Maintainer: No one, previous maintainer no longer wishes to be a maintainer see #15723 (comment)

Compile tested: N/A
Run tested: Linksys WRT3200ACM OpenWrt 19.07.7

Description:

This adds multi WAN trigger support for stubby, in the stubby config you can now supply multiple WAN interfaces separated with a space, currently you cannot do this. For multi WAN environments you would most likely want to have Stubby be able to have triggers on multiple WAN interfaces to not break DNS resolution if a WAN interface goes down.

Original credit/author: https://forum.openwrt.org/t/stubby-option-trigger-help/56694

As this is minor change to the init script, can this also be cherry picked across 21.02 and 19.07?

@dibdot
Copy link
Contributor

dibdot commented Aug 6, 2021

Hi, thanks for the contribution. A few remarks:

Thanks!

Signed-off-by: James White <james@jmwhite.co.uk>
@jamesmacwhite
Copy link
Contributor Author

Hi @dibdot, thanks for your feedback and guidance! I have updated the PR as requested with those changes.

Please me know if this is OK and ready for merging.

@dibdot
Copy link
Contributor

dibdot commented Aug 7, 2021

LGTM - many thanks!

@dibdot dibdot merged commit cfc1c6a into openwrt:master Aug 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants