strongswan: Add dependency to virtual package strongswan-mod-socket #16367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pprindeville
force-pushed
the
strongswan-mod-socket-dep
branch
from
8efd948
to
4f9b602
Compare
stintel
added a commit
to stintel/openwrt-packages
that referenced
this pull request
Aug 15, 2021
This a virtual package that is satisfied by either strongswan-mod-socket-default or strongswan-mod-socket-dynamic, and is required by the charon daemon. When neither of these packages is installed, charon will not function. Closes openwrt#16261, openwrt#16263 and openwrt#16367. Signed-off-by: Noel Kuntze <noel.kuntze@thermi.consulting> Signed-off-by: Philip Prindeville <philipp@redfish-solutions.com> Signed-off-by: Stijn Tintel <stijn@linux-ipv6.be>
stintel
added a commit
to stintel/openwrt-packages
that referenced
this pull request
Aug 15, 2021
This a virtual package that is satisfied by either strongswan-mod-socket-default or strongswan-mod-socket-dynamic, and is required by the charon daemon. When neither of these packages is installed, charon will not function. Closes openwrt#16261, openwrt#16263 and openwrt#16367. Signed-off-by: Noel Kuntze <noel.kuntze@thermi.consulting> Signed-off-by: Philip Prindeville <philipp@redfish-solutions.com> Signed-off-by: Stijn Tintel <stijn@linux-ipv6.be>
pprindeville
pushed a commit
to pprindeville/packages
that referenced
this pull request
Aug 15, 2021
This a virtual package that is satisfied by either strongswan-mod-socket-default or strongswan-mod-socket-dynamic, and is required by the charon daemon. When neither of these packages is installed, charon will not function. Closes openwrt#16261, openwrt#16263 and openwrt#16367. Signed-off-by: Noel Kuntze <noel.kuntze@thermi.consulting> Signed-off-by: Philip Prindeville <philipp@redfish-solutions.com> Signed-off-by: Stijn Tintel <stijn@linux-ipv6.be>
pprindeville
force-pushed
the
strongswan-mod-socket-dep
branch
from
4f9b602
to
d764449
Compare
pprindeville
pushed a commit
to pprindeville/packages
that referenced
this pull request
Aug 15, 2021
This a virtual package that is satisfied by either strongswan-mod-socket-default or strongswan-mod-socket-dynamic, and is required by the charon daemon. When neither of these packages is installed, charon will not function. Closes openwrt#16261, openwrt#16263 and openwrt#16367. Signed-off-by: Noel Kuntze <noel.kuntze@thermi.consulting> Signed-off-by: Philip Prindeville <philipp@redfish-solutions.com> Signed-off-by: Stijn Tintel <stijn@linux-ipv6.be>
pprindeville
force-pushed
the
strongswan-mod-socket-dep
branch
from
d764449
to
437d42f
Compare
stintel
added a commit
to stintel/openwrt-packages
that referenced
this pull request
Aug 15, 2021
This a virtual package that is satisfied by either strongswan-mod-socket-default or strongswan-mod-socket-dynamic, and is required by the charon daemon. When neither of these packages is installed, charon will not function. Closes openwrt#16261, openwrt#16263 and openwrt#16367. Signed-off-by: Noel Kuntze <noel.kuntze@thermi.consulting> Signed-off-by: Philip Prindeville <philipp@redfish-solutions.com> Signed-off-by: Stijn Tintel <stijn@linux-ipv6.be>
|
You need to pull in my latest changes. I was still building an image for runtime test, and was about to open another PR then. Unfortunately I now have issues building nettle, blocking my runtime test. |
stintel
added a commit
to stintel/openwrt-packages
that referenced
this pull request
Aug 15, 2021
This a virtual package that is satisfied by either strongswan-mod-socket-default or strongswan-mod-socket-dynamic, and is required by the charon daemon. When neither of these packages is installed, charon will not function. Closes openwrt#16261, openwrt#16263 and openwrt#16367. Signed-off-by: Noel Kuntze <noel.kuntze@thermi.consulting> Signed-off-by: Philip Prindeville <philipp@redfish-solutions.com> Signed-off-by: Stijn Tintel <stijn@linux-ipv6.be>
stintel
added a commit
to stintel/openwrt-packages
that referenced
this pull request
Aug 15, 2021
This a virtual package that is satisfied by either strongswan-mod-socket-default or strongswan-mod-socket-dynamic, and is required by the charon daemon. When neither of these packages is installed, charon will not function. Closes openwrt#16261, openwrt#16263 and openwrt#16367. Signed-off-by: Noel Kuntze <noel.kuntze@thermi.consulting> Signed-off-by: Philip Prindeville <philipp@redfish-solutions.com> Signed-off-by: Stijn Tintel <stijn@linux-ipv6.be>
stintel
added a commit
to stintel/openwrt-packages
that referenced
this pull request
Aug 16, 2021
This a virtual package that is satisfied by either strongswan-mod-socket-default or strongswan-mod-socket-dynamic, and is required by the charon daemon. When neither of these packages is installed, charon will not function. Closes openwrt#16261, openwrt#16263 and openwrt#16367. Signed-off-by: Noel Kuntze <noel.kuntze@thermi.consulting> Signed-off-by: Philip Prindeville <philipp@redfish-solutions.com> Signed-off-by: Stijn Tintel <stijn@linux-ipv6.be>
stintel
added a commit
to stintel/openwrt-packages
that referenced
this pull request
Aug 16, 2021
This a virtual package that is satisfied by either strongswan-mod-socket-default or strongswan-mod-socket-dynamic, and is required by the charon daemon. When neither of these packages is installed, charon will not function. Closes openwrt#16261, openwrt#16263 and openwrt#16367. Signed-off-by: Noel Kuntze <noel.kuntze@thermi.consulting> Signed-off-by: Philip Prindeville <philipp@redfish-solutions.com> Signed-off-by: Stijn Tintel <stijn@linux-ipv6.be>
pprindeville
commented
Aug 16, 2021
stintel
added a commit
to stintel/openwrt-packages
that referenced
this pull request
Aug 18, 2021
This a virtual package that is satisfied by either strongswan-mod-socket-default or strongswan-mod-socket-dynamic, and is required by the charon daemon. When neither of these packages is installed, charon will not function. Closes openwrt#16261, openwrt#16263 and openwrt#16367. Signed-off-by: Noel Kuntze <noel.kuntze@thermi.consulting> Signed-off-by: Philip Prindeville <philipp@redfish-solutions.com> Signed-off-by: Stijn Tintel <stijn@linux-ipv6.be>
stintel
added a commit
to stintel/openwrt-packages
that referenced
this pull request
Aug 18, 2021
This a virtual package that is satisfied by either strongswan-mod-socket-default or strongswan-mod-socket-dynamic, and is required by the charon daemon. When neither of these packages is installed, charon will not function. Closes openwrt#16261, openwrt#16263 and openwrt#16367. Signed-off-by: Noel Kuntze <noel.kuntze@thermi.consulting> Signed-off-by: Philip Prindeville <philipp@redfish-solutions.com> Signed-off-by: Stijn Tintel <stijn@linux-ipv6.be>
stintel
added a commit
to stintel/openwrt-packages
that referenced
this pull request
Aug 18, 2021
This a virtual package that is satisfied by either strongswan-mod-socket-default or strongswan-mod-socket-dynamic, and is required by the charon daemon. When neither of these packages is installed, charon will not function. Closes openwrt#16261, openwrt#16263 and openwrt#16367. Signed-off-by: Noel Kuntze <noel.kuntze@thermi.consulting> Signed-off-by: Philip Prindeville <philipp@redfish-solutions.com> Signed-off-by: Stijn Tintel <stijn@linux-ipv6.be>
stintel
added a commit
to stintel/openwrt-packages
that referenced
this pull request
Aug 20, 2021
This a virtual package that is satisfied by either strongswan-mod-socket-default or strongswan-mod-socket-dynamic, and is required by the charon daemon. When neither of these packages is installed, charon will not function. Closes openwrt#16261, openwrt#16263 and openwrt#16367. Signed-off-by: Noel Kuntze <noel.kuntze@thermi.consulting> Signed-off-by: Philip Prindeville <philipp@redfish-solutions.com> Signed-off-by: Stijn Tintel <stijn@linux-ipv6.be>
|
Ah sorry. This issue seems to be fixed... |
pprindeville
pushed a commit
to pprindeville/packages
that referenced
this pull request
Feb 3, 2022
This a virtual package that is satisfied by either strongswan-mod-socket-default or strongswan-mod-socket-dynamic, and is required by the charon daemon. When neither of these packages is installed, charon will not function. Closes openwrt#16261, openwrt#16263 and openwrt#16367. Signed-off-by: Noel Kuntze <noel.kuntze@thermi.consulting> Signed-off-by: Philip Prindeville <philipp@redfish-solutions.com> Signed-off-by: Stijn Tintel <stijn@linux-ipv6.be>
pprindeville
force-pushed
the
strongswan-mod-socket-dep
branch
from
437d42f
to
d745975
Compare
pprindeville
pushed a commit
to pprindeville/packages
that referenced
this pull request
Feb 4, 2022
This a virtual package that is satisfied by either strongswan-mod-socket-default or strongswan-mod-socket-dynamic, and is required by the charon daemon. When neither of these packages is installed, charon will not function. Closes openwrt#16261, openwrt#16263 and openwrt#16367. Signed-off-by: Noel Kuntze <noel.kuntze@thermi.consulting> Signed-off-by: Philip Prindeville <philipp@redfish-solutions.com> Signed-off-by: Stijn Tintel <stijn@linux-ipv6.be>
pprindeville
force-pushed
the
strongswan-mod-socket-dep
branch
from
d745975
to
bf876c0
Compare
This a virtual package that is satisfied by either strongswan-mod-socket-default or strongswan-mod-socket-dynamic, and is required by the charon daemon. When neither of these packages is installed, charon will not function. Closes openwrt#16261, openwrt#16263 and openwrt#16367. Signed-off-by: Noel Kuntze <noel.kuntze@thermi.consulting> Signed-off-by: Philip Prindeville <philipp@redfish-solutions.com> Signed-off-by: Stijn Tintel <stijn@linux-ipv6.be>
pprindeville
force-pushed
the
strongswan-mod-socket-dep
branch
from
bf876c0
to
603f70e
Compare
|
@CodeFetch @Neustradamus Can someone please test this? |
|
There is a progress on this PR? |
Still need it tested. |
|
I'd say it works |
|
Why was this merged, even though I said in #16373 it was no good? It causes the following problem: |
|
Thank you @stintel!
I guess we were too quick with the merge. I took some time this morning to take a look and the issue disappears if we just use the virtual provider instead of socket-default. The error message is not useful tbh because it does not describe a circular dependency.
I still need to check if doing that change doesn't cause unsatisfiable dependencies.
Am 16. August 2022 12:21:59 UTC schrieb Stijn Tintel ***@***.***>:
Why was this merged, even though I said in #16373 it was no good? It causes the following problem:
```
tmp/.config-package.in:122354:error: recursive dependency detected!
tmp/.config-package.in:122354: symbol PACKAGE_strongswan-default depends on PACKAGE_strongswan-mod-socket-default
tmp/.config-package.in:123534: symbol PACKAGE_strongswan-mod-socket-default is selected by PACKAGE_strongswan-default
```
--
Reply to this email directly or view it on GitHub:
#16367 (comment)
You are receiving this because you were mentioned.
Message ID: ***@***.***>
--
Sent from mobile
|
|
That whole circular dependency stuff is a disaster. It's the main reason I gave up on #16373 as I could just select the proper package in my .config and get on with life. |
|
I fixed the issue, see #19184 |
stokito
pushed a commit
to stokito/packages
that referenced
this pull request
Dec 6, 2022
This a virtual package that is satisfied by either strongswan-mod-socket-default or strongswan-mod-socket-dynamic, and is required by the charon daemon. When neither of these packages is installed, charon will not function. Closes openwrt#16261, openwrt#16263 and openwrt#16367. Signed-off-by: Noel Kuntze <noel.kuntze@thermi.consulting> Signed-off-by: Philip Prindeville <philipp@redfish-solutions.com> Signed-off-by: Stijn Tintel <stijn@linux-ipv6.be>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maintainer: me, @Thermi
Compile tested: x86_64, generic, HEAD (f038a16)
Run tested: same, installed on test VM
Description:
Originally by Noel Kuntze, and refined by Stijn Tintel.