Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: add PKG-INFO metadata file #17100

Merged
merged 1 commit into from Nov 9, 2021
Merged

Conversation

Habbie
Copy link
Contributor

@Habbie Habbie commented Nov 8, 2021

As briefly discussed in #17078 (cc @aparcar), this PR:

  • adds PR numbers to the artifact file names
  • shortens the git hashes in the file names (and prefixes them with g)
  • adds a PKG-INFO file that is compatible with Python's packaging metadata, and therefore very easy to read with https://pypi.org/project/pkginfo/ (but also without, it's just a mail headers-like plain text file in the zip)

Comments welcome!

@aparcar
Copy link
Member

aparcar commented Nov 8, 2021

Please prefix this with CI: and not GH CI artifacts

@Habbie Habbie changed the title GH CI artifacts: add PKG-INFO metadata file CI: add PKG-INFO metadata file Nov 8, 2021
@aparcar
Copy link
Member

aparcar commented Nov 8, 2021

shortens the git hashes in the file names (and prefixes them with g)

Please remove the g, I think more people will think it's part of the hash and end up confused.

@aparcar
Copy link
Member

aparcar commented Nov 8, 2021

Apart from that I think it's very cool, thank for working on this!

@Habbie
Copy link
Contributor Author

Habbie commented Nov 8, 2021

Please remove the g, I think more people will think it's part of the hash and end up confused.

You're the second to say that! I'll do that :)

@Habbie
Copy link
Contributor Author

Habbie commented Nov 8, 2021

g removed (amend/force push)

Signed-off-by: Peter van Dijk <peter.van.dijk@powerdns.com>
@aparcar
Copy link
Member

aparcar commented Nov 9, 2021

Okay looks good! Thanks for you work. @neheb mind having a quick look?

@aparcar aparcar merged commit a40c1b3 into openwrt:master Nov 9, 2021
@Habbie Habbie deleted the artifact-metadata branch November 9, 2021 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants