Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conntrack-tools: import patch to fix cache #17148

Merged
merged 1 commit into from Nov 20, 2021

Conversation

PolynomialDivision
Copy link
Member

@PolynomialDivision PolynomialDivision commented Nov 18, 2021

As written in the commit message:

Depending on your conntrackd configuration, events might get lost,
leaving stuck entries in the cache forever. Skip checking the conntrack
ID to allow for lazy cleanup by when a new entry that is represented by
the same tuple is added.

Maintainer: @jow-
Compile tested: Edge Router 4 (trunk)
Run tested: Edge Router 4

@PolynomialDivision PolynomialDivision changed the title [WIP] conntrack-tools: import fixing cache grows [WIP] conntrack-tools: import patch to fix cache Nov 18, 2021
As written in the commit message:

Depending on your conntrackd configuration, events might get lost,
leaving stuck entries in the cache forever. Skip checking the conntrack
ID to allow for lazy cleanup by when a new entry that is represented by
the same tuple is added.

Signed-off-by: Nick Hainke <vincent@systemli.org>
@PolynomialDivision PolynomialDivision changed the title [WIP] conntrack-tools: import patch to fix cache conntrack-tools: import patch to fix cache Nov 18, 2021
@PolynomialDivision
Copy link
Member Author

@PolynomialDivision
Copy link
Member Author

Okay, I saw that @neheb did the last merges. Could you merge this? This is a very important fix otherwise, the cache will grow without any bound and kill the synchronization. I run-tested that now in a asymmetric routing bgp structure for several days and it fixes everything.

@neheb neheb merged commit da619f1 into openwrt:master Nov 20, 2021
@PolynomialDivision
Copy link
Member Author

Thanks! :)

@PolynomialDivision PolynomialDivision deleted the conntrack-fix branch January 20, 2022 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants