Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

miniupnp: update to version 2.2.3 #17469

Merged
merged 2 commits into from Jan 5, 2022
Merged

miniupnp: update to version 2.2.3 #17469

merged 2 commits into from Jan 5, 2022

Conversation

shalzz
Copy link
Contributor

@shalzz shalzz commented Jan 1, 2022 •
edited

With refreshed patches

@shalzz shalzz force-pushed the master branch 2 times, most recently from a0829f0 to 2f0adb8 Compare January 1, 2022 07:34
@shalzz
Copy link
Contributor Author

shalzz commented Jan 1, 2022

This version fixes the MS IGDv1 issues (miniupnp/miniupnp#539) and so the IGDv1 variant should probably be removed.

@shalzz shalzz force-pushed the master branch 2 times, most recently from e802dab to 13e33eb Compare January 1, 2022 12:44
@shalzz
Copy link
Contributor Author

shalzz commented Jan 2, 2022 •
edited

Okay, updated and tested to work

@shalzz shalzz force-pushed the master branch 2 times, most recently from 66d3306 to c8c93e1 Compare January 2, 2022 10:29
@PolynomialDivision
Copy link
Member

Can you seperate that into two commits and prefix it with the correct package name, so miniupnpc. If actually the package miniupnp, we should maybe think about combining both packages.

@shalzz
miniupnpd: update to version 2.2.3
dd1d534 
Signed-off-by: Shaleen Jain <shaleen@jain.sh>
@shalzz
miniupnpc: update to version 2.2.3
b4c16d5 
Signed-off-by: Shaleen Jain <shaleen@jain.sh>
@shalzz
Copy link
Contributor Author

shalzz commented Jan 4, 2022

Can you seperate that into two commits and prefix it with the correct package name, so miniupnpc. If actually the package miniupnp, we should maybe think about combining both packages.

Done. Do you want me to create them as separate PRs?

@PolynomialDivision
Copy link
Member

Done. Do you want me to create them as separate PRs?

No, everything fine. Even better since they originate from the same project. :) I will wait for CI to pass and then I will merge.

@PolynomialDivision PolynomialDivision merged commit 8201086 into openwrt:master Jan 5, 2022
@stintel
Copy link
Member

stintel commented Jan 5, 2022

Next time please search open PRs first: #17094

@PolynomialDivision
Copy link
Member

Next time please search open PRs first: #17094

Sorry. Can you maybe add yourself as PKG_MAINTAINER?

@stintel
Copy link
Member

stintel commented Jan 5, 2022

Can you maybe add yourself as PKG_MAINTAINER?

Considering it!

@stintel
Copy link
Member

stintel commented Jan 7, 2022

After looking at the existing issues for miniupnpd I think I'll pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PolynomialDivision PolynomialDivision PolynomialDivision left review comments

@openips openips openips approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@shalzz @PolynomialDivision @stintel @openips