Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isc-dhcp: detect whether ddns transfers are IPv4 only #18061

Merged
merged 1 commit into from
Mar 15, 2022

Conversation

pprindeville
Copy link
Member

@pprindeville pprindeville commented Mar 15, 2022

Maintainer: me
Compile tested: x86_64, generic, HEAD (236c3ea)
Run tested: same, installed on production router

Description:

If named is configured to not listen on any IPv6 interfaces,
then we should run 'nsupdate' with the '-4' argument.

Also:

  • cleanup RFC-1918 address detection;
  • don't generate PTR records for domain entries that aren't
    RFC-1918 addresses or these will generate NOTAUTH failures;

We're assuming that we're doing DNS split-horizon and that
internal addresses aren't routable.

@pprindeville
Copy link
Member Author

@dwfreed Ended up using your sed suggestion.

@pprindeville pprindeville force-pushed the isc-dhcp-fix-ddns-updates branch 3 times, most recently from 5b5ba76 to d0c1e9e Compare March 15, 2022 17:55
If named is configured to not listen on any IPv6 interfaces,
then we should run 'nsupdate' with the '-4' argument.

Also:

* cleanup RFC-1918 address detection;
* don't generate PTR records for domain entries that aren't
  RFC-1918 addresses or these will generate NOTAUTH failures;

We're assuming that we're doing DNS split-horizon and that
internal addresses aren't routable.

Signed-off-by: Philip Prindeville <philipp@redfish-solutions.com>
@pprindeville pprindeville merged commit 59b89ae into openwrt:master Mar 15, 2022
@pprindeville pprindeville deleted the isc-dhcp-fix-ddns-updates branch March 15, 2022 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant