Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libgd: add conflicts to each other #19230

Merged
merged 1 commit into from Aug 24, 2022
Merged

libgd: add conflicts to each other #19230

merged 1 commit into from Aug 24, 2022

Conversation

BKPepe
Copy link
Member

@BKPepe BKPepe commented Aug 22, 2022

Maintainer: @jow- introduced by @flyn-org in 0762c72
Compile tested: N/A
Run tested: N/A

The full variant should conflict with the default variant. This prevents that
libgd and libgd-full could be installed side by side, and also, the full
variant should provide the libgd. Otherwise, if you install libgd-full,
you can not install vnstat.

Fixes: https://forum.turris.cz/t/updater-okpg-collision-of-dependencies/17520/3

The full variant should conflict with the default variant. This prevents that
libgd and libgd-full could be installed side by side, and also, the full
variant should provide the libgd. Otherwise, if you install libgd-full,
you can not install vnstat.

Signed-off-by: Josef Schlehofer <pepe.schlehofer@gmail.com>
@flyn-org
Copy link
Contributor

Looks good. Recommend merge.

@neheb neheb merged commit 42b36b7 into openwrt:master Aug 24, 2022
@hnyman
Copy link
Contributor

hnyman commented Sep 3, 2022

This caused dependency conflict.

perus@ub2204:/Openwrt/r7800$ make defconfig
Collecting package info: done
tmp/.config-package.in:59546:warning: leading whitespace ignored
tmp/.config-package.in:53246:error: recursive dependency detected!
tmp/.config-package.in:53246:	symbol PACKAGE_libgd is selected by PACKAGE_libgd-full
tmp/.config-package.in:53280:	symbol PACKAGE_libgd-full depends on PACKAGE_libgd
For a resolution refer to Documentation/kbuild/kconfig-language.rst
subsection "Kconfig recursive dependency limitations"

The basic/default variant should have a different name than the full variant's PROVIDES.

e.g. libgd-basic and libgd-full, and both provide libgd, and libgd-full conflicts with libgd-basic.

Ps.

Compile tested: N/A

Even running make defconfig should have revealed the created config conflict.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants