collectd: re-enable nut plugin

[hnyman]

Re-enable the nut plugin (remove BROKEN mark).
Nut itself has been patched to provide better compatible time_t.

I have not not run-tested the plugin, so it is still possible that the fixes from upstream collectd PR 4043 are needed.

Maintainer: me
Compile tested: ipq806x/R7800
Run tested: none

[hnyman]

Interestingly, the CI seems to fail related to ltq-dsl stuff that has nothing to do with nut.
e.g. https://github.com/openwrt/packages/actions/runs/3077761011/jobs/4972844848

Just wondering if that is temporary, or if the recent Lantiq dsl module changes by @dhewg screwed something.

I will merge this PR (related to the nut plugin) , and let's see what happens with collectd in the buildbot itself.

[dhewg]

CI passed on my earlier PR at least, so I'm not sure. Maybe indirectly via a dependency, but at first glance I don't see how?

[dhewg]

This CI on the package feed uses the SDK from base, maybe that's not up to date yet?

[akosiaris]

@dhewg @hnyman Hi, I know this is old, but CI is still broken 6 months down the line, so this wasn't temporary after all. See #20662 where I try to do something completely unrelated only to have compilations errors due to ltq-dsl. See #20662 (comment), as well as the build logs. I had a quick look to see if I can fix it, but I am apparently out of my league here.

[dhewg]

Can you try if using @ltq-dsl-app instead of just ltq-dsl-app in the last line of the collectd Makefile fixes it?

[akosiaris]

Can you try if using @ltq-dsl-app instead of just ltq-dsl-app in the last line of the collectd Makefile fixes it?

And it indeed it does (just ran CI locally). Thanks for the hint! I 'll upload a PR to fix this. and rebase #20662 on top of that one.

[dhewg]

Nice!
Can you please fix prometheus-node-exporter-lua-ltq-dsl in the same fashion?

[akosiaris]

Nice! Can you please fix prometheus-node-exporter-lua-ltq-dsl in the same fashion?

I can do so, but that package appears to be broken in it's own fashion. Running CI on git master (with or without prefixing ltq-dsl-app with a @) for that package I get

| /home/build/openwrt/staging_dir/toolchain-x86_64_gcc-12.2.0_musl/bin/../lib/gcc/x86_64-openwrt-linux-musl/12.2.0/../../../../x86_64-openwrt-linux-musl/bin/ld: /home/build/openwrt/build_dir/target-x86_64_musl/hostapd-wpad-basic/hostapd-2022-07-29-b704dc72/wpa_supplicant/wpa_supplicant_multi.a(mbo.o): in function `mbo_build_anqp_buf':
| mbo.c:(.text+0xbc5): undefined reference to `gas_anqp_add_element'
| /home/build/openwrt/staging_dir/toolchain-x86_64_gcc-12.2.0_musl/bin/../lib/gcc/x86_64-openwrt-linux-musl/12.2.0/../../../../x86_64-openwrt-linux-musl/bin/ld: mbo.c:(.text+0xc2b): undefined reference to `gas_anqp_set_element_len'

I can upload a PR for that package specifically to raise awareness to that unrelated issue too.

[dhewg]

That's hostapd failing... no idea
CI fails with random crap way to often

[akosiaris]

CI fails with random crap way to often

Heh, took me a while, but I think I got a glimpse of what you mean. As a case in point, meet https://github.com/openwrt/packages/actions/runs/4499341213?pr=20709. The change is just that single @ character prefixed in ltq-dsl-app.

9 jobs in the GH action, 6 fail.

4 fail because somehow (I am pretty sure I don't want to dive deeper into this rabbit hole anymore), libavahi-nodbus-support AND libavahi-dbus-support get built as ipks and the Test Container step tries to install them in series only to fail with

Collected errors:
 * check_data_file_clashes: Package libavahi-dbus-support wants to install file /usr/lib/libavahi-common.so.3
	But that file is already provided by package  * libavahi-nodbus-support
 * check_data_file_clashes: Package libavahi-dbus-support wants to install file /usr/lib/libavahi-common.so.3.5.4
	But that file is already provided by package  * libavahi-nodbus-support
 * check_data_file_clashes: Package libavahi-dbus-support wants to install file /usr/lib/libavahi-core.so.7
	But that file is already provided by package  * libavahi-nodbus-support
 * check_data_file_clashes: Package libavahi-dbus-support wants to install file /usr/lib/libavahi-core.so.7.1.0
	But that file is already provided by package  * libavahi-nodbus-support
 * opkg_install_cmd: Cannot install package avahi-dbus-daemon.

The other 2 (both on mips) fail with some assembler messages

{standard input}: Assembler messages:
{standard input}:33: Error: invalid operands `lw $10,12($sp)'
{standard input}:34: Error: invalid operands `lw $11,16($sp)'
{standard input}:35: Error: invalid operands `lw $12,4($sp)'
<snip>
...

Funnily enough, I only got into this cause I wrote some simple shell script stuff to allow configuring the mqtt collectd mod via uci. Somehow I ended up staring at assembly errors and unrelated (to my change) package installation conflicts.