ddns-scripts: store device's current IP in <section>.curr_ip file #19475
+4
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rmilecki
commented
Sep 28, 2022
rmilecki
commented
This should be useful for user interfaces (e.g. LuCI) to display DDNS status. If current IP differs from registered IP it may suggest user that there is a problem. It could happen if DNS change hasn't propagated yet or DDNS provider refused change for some reason. Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
|
@rmilecki instead of saving the current ip, can't we just use ddns functions to get the current one at runtime? I agree that this would be a handy feature to also understand what ddns is detecting with the current configuration as the ip to comunicate with the ddns provider. |
|
I see that this needs to be rebased. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.