treewide: fix procd service inactive #19617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exit directly will result procd service inactive and uci configuration changes are no longer monitored. Reported-by: Lvc Revincx <revincx233@gmail.com> Signed-off-by: Tianling Shen <cnsztl@immortalwrt.org>
|
That is…interesting. Given that AUTORELEASE doesn’t really work with treewide, I think it makes more sense to make multiple commits with each package. wonder how many other packages are affected… |
https://github.com/openwrt/packages/actions/runs/3265617495/jobs/5368113799#step:8:54
Yes, that's what I actually did before.
adguardhome and hs20 at least. EDIT:
|
Thanks to @1715173329 I've just fixed simple-adblock. PR pending. |
stangri
added a commit
to stangri/packages
that referenced
this pull request
Oct 18, 2022
* make PKG_VERSION of the init script readonly to remove shellcheck exception * replace exit with return in the the procd scripts per: openwrt#19617 * remove custom boot() function as it prevented creation of procd firewall object on start on boot Signed-off-by: Stan Grishin <stangri@melmac.ca>
stangri
added a commit
to stangri/packages
that referenced
this pull request
Oct 18, 2022
* make PKG_VERSION of the init script readonly to remove shellcheck exception * replace exit with return in the the procd scripts per: openwrt#19617 * remove custom boot() function as it prevented creation of procd firewall object on start on boot Signed-off-by: Stan Grishin <stangri@melmac.ca> (cherry picked from commit d691408)
stangri
added a commit
to stangri/packages
that referenced
this pull request
Oct 18, 2022
* make PKG_VERSION of the init script readonly to remove shellcheck exception * replace exit with return in the the procd scripts per: openwrt#19617 * remove custom boot() function as it prevented creation of procd firewall object on start on boot * improve performance of allowing domains code Signed-off-by: Stan Grishin <stangri@melmac.ca>
stangri
added a commit
to stangri/packages
that referenced
this pull request
Oct 18, 2022
* make PKG_VERSION of the init script readonly to remove shellcheck exception * replace exit with return in the the procd scripts per: openwrt#19617 * remove custom boot() function as it prevented creation of procd firewall object on start on boot * improve performance of allowing domains code Signed-off-by: Stan Grishin <stangri@melmac.ca> (cherry picked from commit 3ba5455)
stokito
pushed a commit
to stokito/packages
that referenced
this pull request
Dec 6, 2022
* make PKG_VERSION of the init script readonly to remove shellcheck exception * replace exit with return in the the procd scripts per: openwrt#19617 * remove custom boot() function as it prevented creation of procd firewall object on start on boot * improve performance of allowing domains code Signed-off-by: Stan Grishin <stangri@melmac.ca>
SibrenVasse
pushed a commit
to SibrenVasse/packages
that referenced
this pull request
Feb 26, 2023
* make PKG_VERSION of the init script readonly to remove shellcheck exception * replace exit with return in the the procd scripts per: openwrt#19617 * remove custom boot() function as it prevented creation of procd firewall object on start on boot * improve performance of allowing domains code Signed-off-by: Stan Grishin <stangri@melmac.ca> (cherry picked from commit 3ba5455)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maintainer: me
Compile tested: N/A
Run tested: NanoPi R2S
Description:
Exit directly will result procd service inactive and uci configuration changes are no longer monitored.