Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shadowsocks-libev: ss-rules: Add 'auto-merge' flag to avoid conflicts #19872

Closed
wants to merge 2 commits into from

Conversation

crzidea
Copy link
Contributor

@crzidea crzidea commented Nov 10, 2022

Signed-off-by: Li Xin i@crzidea.com

Maintainer: @yousong
Compile tested: ramips/mt7621 OpenWrt 22.03.2
Run tested: ramips/mt7621 OpenWrt 22.03.2
Description:

Need auto-merge flag to solve CIDR elements conflicts, example:
http://git.netfilter.org/nftables/commit/?id=30f667920601d01107398cbb85da45fdb1237212

@crzidea crzidea changed the title Add 'auto-merge' flag to avoid conflicts ss-rules: Add 'auto-merge' flag to avoid conflicts Nov 14, 2022
@crzidea crzidea force-pushed the patch-1 branch 2 times, most recently from 1a6d668 to 482cdd4 Compare November 14, 2022 11:39
@BKPepe BKPepe requested a review from yousong November 14, 2022 22:36
@crzidea crzidea changed the title ss-rules: Add 'auto-merge' flag to avoid conflicts shadowsocks-libev: ss-rules: Add 'auto-merge' flag to avoid conflicts Nov 16, 2022
@1715173329
Copy link
Member

Ping @yousong

@yousong
Copy link
Member

yousong commented Nov 21, 2022

I remember last time I checked it, auto-merge will cause the set refusing to accept plain ip addresses, e.g. 8.8.8.8 vs. 8.8.8.8/32. Is it still the case?

@crzidea
Copy link
Contributor Author

crzidea commented Jan 13, 2023

I remember last time I checked it, auto-merge will cause the set refusing to accept plain ip addresses, e.g. 8.8.8.8 vs. 8.8.8.8/32. Is it still the case?

@yousong I have checked again, it does not cause the issue now. Below is just an evidence, just used nft to list the working ruleset, and 192.168.2.254 is working together with auto-merge:

# nft -a list ruleset | head
table inet fw4 { # handle 1
	set ss_rules_src_bypass { # handle 52
		type ipv4_addr
		flags interval
		auto-merge
		elements = { 192.168.2.50, 192.168.2.53,
			     192.168.2.254 }
	}

	set ss_rules6_src_bypass { # handle 53

@yousong
Copy link
Member

yousong commented Jan 13, 2023

I remember last time I checked it, auto-merge will cause the set refusing to accept plain ip addresses, e.g. 8.8.8.8 vs. 8.8.8.8/32. Is it still the case?

@yousong I have checked again, it does not cause the issue now. Below is just an evidence, just used nft to list the working ruleset, and 192.168.2.254 is working together with auto-merge:

# nft -a list ruleset | head
table inet fw4 { # handle 1
	set ss_rules_src_bypass { # handle 52
		type ipv4_addr
		flags interval
		auto-merge
		elements = { 192.168.2.50, 192.168.2.53,
			     192.168.2.254 }
	}

	set ss_rules6_src_bypass { # handle 53

Likely I remembered it wrong. I think it's worth a try again ;)

Please increment PKG_RELEASE in the Makefile.

@yousong
Copy link
Member

yousong commented Jan 17, 2023

@crzidea The new commit likely will fail the ci check for lacking Signed-off-by signature. Consider just squashing them into a single commit. Thank you.

yousong pushed a commit that referenced this pull request Jan 28, 2023
Link: #19872
Signed-off-by: Li Xin <i@crzidea.com>
(squash commits)
Signed-off-by: Yousong Zhou <yszhou4tech@gmail.com>
@yousong
Copy link
Member

yousong commented Jan 28, 2023

Hi @crzidea , I squashed the two commits and the change is now at 8966f49 . Thank you for your contribution.

@yousong yousong closed this Jan 28, 2023
@crzidea crzidea deleted the patch-1 branch January 28, 2023 10:07
@crzidea
Copy link
Contributor Author

crzidea commented May 4, 2023

@yousong When will it be merged to 22.03? I noticed that the latest openwrt 22.03.5 is still with shadowsocks-libev-ss-rules 3.3.5-7.

yousong pushed a commit that referenced this pull request May 4, 2023
Link: #19872
Signed-off-by: Li Xin <i@crzidea.com>
(squash commits)
Signed-off-by: Yousong Zhou <yszhou4tech@gmail.com>
(cherry picked from commit 8966f49)
@yousong
Copy link
Member

yousong commented May 4, 2023

@yousong When will it be merged to 22.03? I noticed that the latest openwrt 22.03.5 is still with shadowsocks-libev-ss-rules 3.3.5-7.

I just did the cherry-pick. Consider giving it a try ;)

@crzidea
Copy link
Contributor Author

crzidea commented May 5, 2023

@yousong When will it be merged to 22.03? I noticed that the latest openwrt 22.03.5 is still with shadowsocks-libev-ss-rules 3.3.5-7.

I just did the cherry-pick. Consider giving it a try ;)

Still not on 22.03. Did you pushed to the branch openwrt-22.03? I checked here and here.

@crzidea
Copy link
Contributor Author

crzidea commented May 8, 2023

@yousong When will it be merged to 22.03? I noticed that the latest openwrt 22.03.5 is still with shadowsocks-libev-ss-rules 3.3.5-7.

I just did the cherry-pick. Consider giving it a try ;)

Still not on 22.03. Did you pushed to the branch openwrt-22.03? I checked here and here.

I see it is 3.3.5-8 now here.

@openwrt openwrt locked and limited conversation to collaborators May 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants