Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emailrelay: update to v2.4.1 #20035

Merged
merged 1 commit into from Dec 20, 2022
Merged

Conversation

stokito
Copy link
Contributor

@stokito stokito commented Dec 6, 2022

Maintainer: @fededim
Compile tested: yes, on Ubuntu amd64

Also please check my #18536

@BKPepe you may be interested

The patch seems not needed anymore.
Also remove deprecated PKG_RELEASE:=$(AUTORELEASE)

Signed-off-by: Sergey Ponomarev <stokito@gmail.com>
@stokito
Copy link
Contributor Author

stokito commented Dec 10, 2022

Please don't merge it until this fixed https://sourceforge.net/p/emailrelay/bugs/52/
I'll update the PR

@stokito stokito marked this pull request as draft December 10, 2022 23:39
@BKPepe
Copy link
Member

BKPepe commented Dec 11, 2022

https://sourceforge.net/p/emailrelay/bugs/52/

Reproduced for Turris OS 6.0.4, which is based on top of the latest OpenWrt 21.02. I think your PR is fine for OpenWrt master, so we can merge this as it is. If you would like to backport your update to the stable releases and be sure that it is compiled, you can open a pull request to the relevant branches.

@1715173329
Copy link
Member

would PKG_FORTIFY_SOURCE:=0 help the build?

@BKPepe
Copy link
Member

BKPepe commented Dec 11, 2022 via email

@stokito stokito marked this pull request as ready for review December 20, 2022 20:15
@stokito
Copy link
Contributor Author

stokito commented Dec 20, 2022

Maybe that compilation error relates to some gcc or musl version and not related to the ER itself.

@BKPepe could we merge the PR now to the OpenWrt? The ER author anyway have nothing to do here and Turris OS build may came latter.

@BKPepe BKPepe merged commit 735cba8 into openwrt:master Dec 20, 2022
@stokito stokito deleted the emailrelay_update_v241 branch December 20, 2022 21:01
@BKPepe
Copy link
Member

BKPepe commented Sep 20, 2023

Backported to OpenWrt 22.03 branch - 0dab01d.

oskarirauta added a commit to oskarirauta/packages that referenced this pull request Oct 13, 2023
Bugfixes

 - Fixed a bug involving non-English locales of Windows where machine installs using user-mode networking were rejected due to erroneous version detection (openwrt#20209).
 - Fixed a regression in --env-file handling (openwrt#19565).
 - Fixed a bug where podman inspect would fail when stat'ing a device failed.

API
 - The network list compat API endpoint is now much faster (openwrt#20035).

Openwrt updates: added patch to allow building with musl-1.2.4
Patch source is from gentoo https://github.com/vimproved/gentoo/blob/c4c349f11a4352be1965726eadfe3a8bd8a6fa9c/app-containers/podman/files/podman-4.5.0-fix-build-with-musl-1.2.4.patch

Issue was discussed by @jefferyto at mattn/go-sqlite3#1177

Signed-off-by: Oskari Rauta <oskari.rauta@gmail.com>
1715173329 pushed a commit that referenced this pull request Oct 14, 2023
Bugfixes

 - Fixed a bug involving non-English locales of Windows where machine installs using user-mode networking were rejected due to erroneous version detection (#20209).
 - Fixed a regression in --env-file handling (#19565).
 - Fixed a bug where podman inspect would fail when stat'ing a device failed.

API
 - The network list compat API endpoint is now much faster (#20035).

Openwrt updates: added patch to allow building with musl-1.2.4
Patch source is from gentoo https://github.com/vimproved/gentoo/blob/c4c349f11a4352be1965726eadfe3a8bd8a6fa9c/app-containers/podman/files/podman-4.5.0-fix-build-with-musl-1.2.4.patch

Issue was discussed by @jefferyto at mattn/go-sqlite3#1177

Signed-off-by: Oskari Rauta <oskari.rauta@gmail.com>
oskarirauta added a commit to oskarirauta/packages that referenced this pull request Oct 14, 2023
Bugfixes

 - Fixed a bug involving non-English locales of Windows where machine installs using user-mode networking were rejected due to erroneous version detection (openwrt#20209).
 - Fixed a regression in --env-file handling (openwrt#19565).
 - Fixed a bug where podman inspect would fail when stat'ing a device failed.

API
 - The network list compat API endpoint is now much faster (openwrt#20035).

Openwrt updates: added patch to allow building with musl-1.2.4
Patch source is from gentoo https://github.com/vimproved/gentoo/blob/c4c349f11a4352be1965726eadfe3a8bd8a6fa9c/app-containers/podman/files/podman-4.5.0-fix-build-with-musl-1.2.4.patch

Issue was discussed by @jefferyto at mattn/go-sqlite3#1177

Signed-off-by: Oskari Rauta <oskari.rauta@gmail.com>
(cherry picked from commit e25d417)
oskarirauta added a commit to oskarirauta/packages that referenced this pull request Oct 14, 2023
Bugfixes

 - Fixed a bug involving non-English locales of Windows where machine installs using user-mode networking were rejected due to erroneous version detection (openwrt#20209).
 - Fixed a regression in --env-file handling (openwrt#19565).
 - Fixed a bug where podman inspect would fail when stat'ing a device failed.

API
 - The network list compat API endpoint is now much faster (openwrt#20035).

Openwrt updates: added patch to allow building with musl-1.2.4
Patch source is from gentoo https://github.com/vimproved/gentoo/blob/c4c349f11a4352be1965726eadfe3a8bd8a6fa9c/app-containers/podman/files/podman-4.5.0-fix-build-with-musl-1.2.4.patch

Issue was discussed by @jefferyto at mattn/go-sqlite3#1177

remarks:
removed musl-1.2.4 patch from commit, since that version of musl
is not available with openwrt-23.05

Signed-off-by: Oskari Rauta <oskari.rauta@gmail.com>
(cherry picked from commit e25d417)
1715173329 pushed a commit that referenced this pull request Oct 14, 2023
Bugfixes

 - Fixed a bug involving non-English locales of Windows where machine installs using user-mode networking were rejected due to erroneous version detection (#20209).
 - Fixed a regression in --env-file handling (#19565).
 - Fixed a bug where podman inspect would fail when stat'ing a device failed.

API
 - The network list compat API endpoint is now much faster (#20035).

Openwrt updates: added patch to allow building with musl-1.2.4
Patch source is from gentoo https://github.com/vimproved/gentoo/blob/c4c349f11a4352be1965726eadfe3a8bd8a6fa9c/app-containers/podman/files/podman-4.5.0-fix-build-with-musl-1.2.4.patch

Issue was discussed by @jefferyto at mattn/go-sqlite3#1177

remarks:
removed musl-1.2.4 patch from commit, since that version of musl
is not available with openwrt-23.05

Signed-off-by: Oskari Rauta <oskari.rauta@gmail.com>
(cherry picked from commit e25d417)
graysky2 pushed a commit to graysky2/packages that referenced this pull request Oct 23, 2023
Bugfixes

 - Fixed a bug involving non-English locales of Windows where machine installs using user-mode networking were rejected due to erroneous version detection (openwrt#20209).
 - Fixed a regression in --env-file handling (openwrt#19565).
 - Fixed a bug where podman inspect would fail when stat'ing a device failed.

API
 - The network list compat API endpoint is now much faster (openwrt#20035).

Openwrt updates: added patch to allow building with musl-1.2.4
Patch source is from gentoo https://github.com/vimproved/gentoo/blob/c4c349f11a4352be1965726eadfe3a8bd8a6fa9c/app-containers/podman/files/podman-4.5.0-fix-build-with-musl-1.2.4.patch

Issue was discussed by @jefferyto at mattn/go-sqlite3#1177

Signed-off-by: Oskari Rauta <oskari.rauta@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants