Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openvpn: Add more hotplug events #21027

Merged
merged 1 commit into from
May 20, 2023
Merged

openvpn: Add more hotplug events #21027

merged 1 commit into from
May 20, 2023

Conversation

miska
Copy link
Contributor

@miska miska commented May 15, 2023

Maintainer: @mkrkn
Compile tested: mvebu, Turris Omnia, TOS 7.0 ~ OpenWrt 22.03
Run tested: mvebu, Turris Omnia, TOS 7.0 ~ OpenWrt 22.03, custom scripts reacting to those events work

Description:

OpenVPN supports more hooks than just 'up' and 'down'. Especially reacting to 'route-up' and 'route-pre-down' events could be important. When routing table changes, it can make sense to adapt firewall, run some tests or change even more routes. This change passes those events to hotplug, so it is easy to react to them without changing configuration files provided by VPN provider.

OpenVPN supports more hooks than just 'up' and 'down'. Especially
reacting to 'route-up' and 'route-pre-down' events could be important.
When routing table changes, it can make sense to adapt firewall, run
some tests or change even more routes. This change passes those events
to hotplug, so it is easy to react to them without changing
configuration files provided by VPN provider.

Signed-off-by: Michal Hrusecky <michal.hrusecky@turris.com>
@neheb neheb merged commit f8a8b71 into openwrt:master May 20, 2023
11 checks passed
@BKPepe
Copy link
Member

BKPepe commented Jun 9, 2023

There are some issues with this pull request and that's why there was created this issue:#21200 and hopefully, it is going to be fixed with this PR (#21245).

admin-turris pushed a commit to turris-cz/os-build that referenced this pull request Dec 14, 2023
OpenVPN supports more hooks than just 'up' and 'down'. Especially
reacting to 'route-up' and 'route-pre-down' events could be important.
When routing table changes, it can make sense to adapt firewall, run
some tests or change even more routes. This change passes those events
to hotplug, so it is easy to react to them without changing
configuration files provided by VPN provider.

This has been sent to upstream, in the meantime, let's have it in house.

openwrt/packages#21027
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants