davfs2: fix inconsistency with HAVE_ICONV and HAVE_ICONV_H #2149
Conversation
Seems that HAVE_ICONV was 1 and HAVE_ICONV_H undefined.
Resulting in build errors like this:
webdav.c: In function 'dav_conv_from_utf_8':
webdav.c:587:9: error: 'from_utf_8' undeclared (first use in this function)
if (from_utf_8)
Also, we're adding $(ICONV_DEPENDS) to the DEPENDS of this package.
Just adding the DEPENDS does not fix.
Seems the patch is still necessary.
Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com>
commodo
force-pushed
the
davfs2-build-fix
branch
from
21ec1b0
to
38d2916
Compare
|
|
|
So, the build seems to fail on x86 & x86.64. I agree that my fix may just overlook a more deeper issue. In any case, if my PR brings about a verification of what's really wrong with those 2 platforms then it's fine. Sent from Samsung Mobile -------- Original message -------- From: Federico Di Marco notifications@github.com Date:22/12/2015 14:37 (GMT+02:00) To: openwrt/packages packages@noreply.github.com Cc: Alexandru Ardelean ardeleanalex@gmail.com Subject: Re: [packages] davfs2: fix inconsistency with HAVE_ICONV and
HAVE_ICONV_H (#2149) — |
|
It seems that during my compilation configure skip some checks (for example iconv library), any idea why ?!? Moreover in your build log it writes a suspicious entry "checking for working iconv... guessing yes"... p.s. obviously I re-downloaded the whole openwrt sources from github after nuking the directory and libiconv-full package is selected in menuconfig. My log Server |
|
I did not know about this, maybe it would be better to add this information to https://wiki.openwrt.org/doc/devel/packages, should someone might want to port any new package based on libiconv or libintl...in any case I would like why my configure behaves differently from the one in the build server http://lists.en.qi-hardware.com/pipermail/discussion/2011-February/007092.html |
|
From my side it's fair to add either a reference to that page or copy the contents to that page into the OpenWRT wiki. I care more about this PR and whether it should go in as is, or a better solution is found :) |
|
Sorry I forgot your old PR which was left unmerged (maintainers were waiting for my ok), I created a new one with your changes #4458. |
Fixes: #1327
Seems that HAVE_ICONV was 1 and HAVE_ICONV_H undefined.
Resulting in build errors like this:
webdav.c: In function 'dav_conv_from_utf_8':
webdav.c:587:9: error: 'from_utf_8' undeclared (first use in this function)
if (from_utf_8)
Also, we're adding $(ICONV_DEPENDS) to the DEPENDS of this package.
Just adding the DEPENDS does not fix.
Seems the patch is still necessary.
Signed-off-by: Alexandru Ardelean ardeleanalex@gmail.com