Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create devcontainer.json #22196

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Create devcontainer.json #22196

wants to merge 1 commit into from

Conversation

bam80
Copy link
Contributor

@bam80 bam80 commented Sep 23, 2023

Maintainer: me
Compile tested: mips, ath79, OpenWrt SNAPSHOT

Description:
Development container configuration.
The container can run locally or in cloud (Codespaces).
Sample usage: easily open full-featured VS Code IDE in browser, pre-configured for OpenWrt packages development.

image

@bam80 bam80 force-pushed the patch-1 branch 2 times, most recently from 106cd13 to 78b07da Compare September 23, 2023 21:57
@bam80
Copy link
Contributor Author

bam80 commented Sep 23, 2023

The same patch for the main repo:
openwrt/openwrt#13520

@BKPepe BKPepe added the blocked label Sep 24, 2023
@BKPepe
Copy link
Member

BKPepe commented Sep 24, 2023

I'm putting this on hold until it is merged in the main repo. We don't need to have discussion on two different repo for the same thing. Let's focus there as I find there some comments interesting one.

@bam80
Copy link
Contributor Author

bam80 commented May 22, 2024

I'm putting this on hold until it is merged in the main repo.

As we added some devcontainer to the main repo,
could we merge this one either?

@BKPepe

Maintainer: me
Compile tested: mips, ath79, OpenWrt SNAPSHOT

Description:
Development container configuration.
The container can run locally or in cloud (Codespaces).
Sample usage: easily open full-featured VS Code IDE in browser,
pre-configured for OpenWrt packages development.

When run in the Codespaces, the packages repo is found in /workspaces/packages.
To add it to the feeds, run inside the container:
$ sed -i '1s;^;src-link workspaces /workspaces/packages\n;' ~/feeds.conf.default

Signed-off-by: Andrey Butirsky <butirsky@gmail.com>
@BKPepe
Copy link
Member

BKPepe commented May 23, 2024

Your same change was not merged to the main repo, yet.

@bam80
Copy link
Contributor Author

bam80 commented May 29, 2024

Your same change was not merged to the main repo, yet.

Could we merge it there, too? I explicitly asked about that just recently:
openwrt/openwrt#13520 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants