Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clixon: Initial packaging #22362

Merged
merged 1 commit into from Dec 6, 2023
Merged

clixon: Initial packaging #22362

merged 1 commit into from Dec 6, 2023

Conversation

pprindeville
Copy link
Member

Maintainer: me, @olofhagsand
Compile tested: x86_64, generic, HEAD (66f6c20)
Run tested: same, installed on test VM

Description:

Clixon is a YANG-based configuration manager, with interactive CLI, NETCONF and RESTCONF interfaces, an embedded database and transaction mechanism.

cc: @olofhagsand

@BKPepe BKPepe self-assigned this Oct 10, 2023
@pprindeville
Copy link
Member Author

Depends on PR #22359

BKPepe
BKPepe requested changes Oct 22, 2023
View reviewed changes
Copy link
Member

@BKPepe BKPepe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Conffiles are missing, I bet there are some.
  2. Comments in the Makefile can be removed
  3. All these patches are included in upstream or pending there?

utils/clixon/Makefile Outdated Show resolved Hide resolved
utils/clixon/Makefile Outdated Show resolved Hide resolved
utils/clixon/Makefile Outdated Show resolved Hide resolved
utils/clixon/Makefile Outdated Show resolved Hide resolved
utils/clixon/Makefile Show resolved Hide resolved
utils/clixon/Makefile Outdated Show resolved Hide resolved
utils/clixon/Makefile Outdated Show resolved Hide resolved
utils/clixon/Makefile Outdated Show resolved Hide resolved
@pprindeville
Copy link
Member Author

Looks like the same cross-build issue with install not knowing how to strip.

Also, while I was looking over the binaries resulting from a build, I realized that a couple of programs had pathnames hard-coded into them. I have a PR for this upstream but @olofhagsand needs to merge it first before I can (temporarily) copy it into the patches/ directory.

@pprindeville pprindeville force-pushed the clixon-initial branch 2 times, most recently from 6e59792 to 91131f4 Compare October 24, 2023 02:52
@pprindeville pprindeville force-pushed the clixon-initial branch 2 times, most recently from 24462ed to 75760c1 Compare November 4, 2023 06:59
@pprindeville pprindeville force-pushed the clixon-initial branch 3 times, most recently from d114451 to 47b4e7d Compare December 5, 2023 17:03
@pprindeville
Copy link
Member Author

  1. Conffiles are missing, I bet there are some.
  2. Comments in the Makefile can be removed
  3. All these patches are included in upstream or pending there?

All of these issues have been addressed. Can I proceed?

BKPepe
BKPepe reviewed Dec 5, 2023
View reviewed changes
utils/clixon/Makefile Outdated Show resolved Hide resolved
BKPepe
BKPepe reviewed Dec 5, 2023
View reviewed changes
utils/clixon/Makefile Outdated Show resolved Hide resolved
BKPepe
BKPepe reviewed Dec 5, 2023
View reviewed changes
utils/clixon/Makefile Outdated Show resolved Hide resolved
@BKPepe
Copy link
Member

BKPepe commented Dec 5, 2023

It seems like recent changes were not pushed, check it out

@pprindeville pprindeville force-pushed the clixon-initial branch 3 times, most recently from 243cc4c to 76adf84 Compare December 5, 2023 17:31
@pprindeville
Copy link
Member Author

It seems like recent changes were not pushed, check it out

Yeah, was doing a test build before pushing...

BKPepe
BKPepe reviewed Dec 5, 2023
View reviewed changes
utils/clixon/Makefile Outdated Show resolved Hide resolved
@pprindeville pprindeville force-pushed the clixon-initial branch 2 times, most recently from a5cb84b to 3d60933 Compare December 5, 2023 17:36
BKPepe
BKPepe reviewed Dec 5, 2023
View reviewed changes
utils/clixon/Makefile Outdated Show resolved Hide resolved
@pprindeville
clixon: Initial packaging
7c3bf47 
Clixon is a YANG-based configuration manager, with interactive CLI,
NETCONF and RESTCONF interfaces, an embedded database and transaction
mechanism.

Signed-off-by: Philip Prindeville <philipp@redfish-solutions.com>
@pprindeville
Copy link
Member Author

@BKPepe Can I please get an approve if everything has been addressed?

@pprindeville
Copy link
Member Author

@BKPepe Can I please get an approve if everything has been addressed?

Okay, if there are follow up review questions I'll do a separate PR.

@pprindeville pprindeville merged commit 94660de into openwrt:master Dec 6, 2023
12 checks passed
@pprindeville pprindeville deleted the clixon-initial branch December 6, 2023 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BKPepe BKPepe BKPepe requested changes

Assignees

@BKPepe BKPepe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pprindeville @BKPepe