Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stress-ng: backport immintrin.h header detection for GCC 13 #22403

Merged
merged 1 commit into from
Oct 22, 2023

Conversation

commodo
Copy link
Contributor

@commodo commodo commented Oct 14, 2023

Maintainer: me
Compile tested: x86_64 openwrt/openwrt@e66eed0
Run tested: n/a

With GCC 12 there is no issue.
With GCC 13, there is a compilation issue on x86_64. Fixes #22373
Fixes #22373

@oskarirauta
Copy link
Contributor

oskarirauta commented Oct 14, 2023

I can verify this. Fixes #22373.
LGTM

@BKPepe
Copy link
Member

BKPepe commented Oct 14, 2023

Maybe, we can slow down a little bit with merging this as upstream is also interested in fixing this.

@commodo
Copy link
Contributor Author

commodo commented Oct 14, 2023

Maybe, we can slow down a little bit with merging this as upstream is also interested in fixing this.

Fine from my side

@oskarirauta
Copy link
Contributor

stress-ng repo was just committed a fix to this issue:
ColinIanKing/stress-ng@cd84c46

I think we could adopt it as a patch, until next version is released. I have not tested if this works or not. I am using original patch from this PR.

@commodo
Copy link
Contributor Author

commodo commented Oct 20, 2023

stress-ng repo was just committed a fix to this issue: ColinIanKing/stress-ng@cd84c46

I think we could adopt it as a patch, until next version is released. I have not tested if this works or not. I am using original patch from this PR.

ack;
will do that now

@commodo commodo force-pushed the stress-ng-disable-immintrin-h branch from cd027c6 to f61d74e Compare October 20, 2023 07:03
@BKPepe
Copy link
Member

BKPepe commented Oct 20, 2023

Commit subject needs to be polished a little bit.

Backport patch from:
   ColinIanKing/stress-ng@cd84c46

With GCC 12 there is no issue.
With GCC 13, there is a compilation issue on x86_64.
Fixes openwrt#22373

Signed-off-by: Alexandru Ardelean <alex@shruggie.ro>
@commodo commodo force-pushed the stress-ng-disable-immintrin-h branch from f61d74e to 1436569 Compare October 20, 2023 09:30
@commodo
Copy link
Contributor Author

commodo commented Oct 20, 2023

Commit subject needs to be polished a little bit.

ack;
was going to do that, but got side-tracked

@commodo commodo changed the title stress-ng: disable immintrin.h header stress-ng: backport immintrin.h header detection for GCC 13 Oct 20, 2023
@BKPepe BKPepe merged commit 98bcb56 into openwrt:master Oct 22, 2023
13 checks passed
@commodo commodo deleted the stress-ng-disable-immintrin-h branch December 18, 2023 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stress-ng 0.17 fails to build on musl-1.2.4
3 participants