-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove compat-libdns_sd #22607
remove compat-libdns_sd #22607
Conversation
anyone even use shairplay? seems it doesn't even work: juhovh/shairplay#80 |
Shairplay seems to be dead, so drop that package. |
@neheb main problem of switching to mdns is that people might have problem and notice the broken package. IMHO shairplay should not be dropped... |
Hmm, while checking it with Ubuntu or Debian, I see that https://salsa.debian.org/multimedia-team/shairplay/-/blob/master/src/lib/dnssd.c which is using this source https://github.com/juhovh/shairplay does not apply the referenced patch. Hard to say, but it looks like it is not developed anymore and that happens. There are several issues opened in that repository and it does not look good, though. However, they packaged and are using https://github.com/mikebrady/shairport-sync client, which works well with PulseAudio, which we do have here: https://github.com/openwrt/packages/blob/56e29ed7daf39b683be49f06cb4bc065b2bdfd35/sound/shairport-sync/Makefile |
I see that in the past @Noltari added and was using this package. Are you still using this or do you know some better alternatives? |
@Ansuel it’s broken already. No need to keep on life support |
This package is not only abandoned upstream, it has not worked with iOS versions since at least 2019: juhovh/shairplay#80 Signed-off-by: Rosen Penev <rosenp@gmail.com>
It seems this is meant for distributions that lack mdnsresponder. It's heavier than it as dbus is required. Since this happens to conflict with mdnsresponder, just remove it. Signed-off-by: Rosen Penev <rosenp@gmail.com>
@Ansuel merging soon if no objections. I want openthread-br built on the buildbots. |
Ok for me. |
Alternative to #22604