Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove compat-libdns_sd #22607

Merged
merged 2 commits into from
Nov 17, 2023
Merged

remove compat-libdns_sd #22607

merged 2 commits into from
Nov 17, 2023

Conversation

neheb
Copy link
Contributor

@neheb neheb commented Nov 6, 2023

Alternative to #22604

@neheb
Copy link
Contributor Author

neheb commented Nov 6, 2023

anyone even use shairplay? seems it doesn't even work: juhovh/shairplay#80

@BKPepe
Copy link
Member

BKPepe commented Nov 6, 2023

Shairplay seems to be dead, so drop that package.

@Ansuel
Copy link
Member

Ansuel commented Nov 6, 2023

@neheb main problem of switching to mdns is that people might have problem and notice the broken package. IMHO shairplay should not be dropped...

@BKPepe
Copy link
Member

BKPepe commented Nov 6, 2023

Hmm, while checking it with Ubuntu or Debian, I see that https://salsa.debian.org/multimedia-team/shairplay/-/blob/master/src/lib/dnssd.c which is using this source https://github.com/juhovh/shairplay does not apply the referenced patch. Hard to say, but it looks like it is not developed anymore and that happens. There are several issues opened in that repository and it does not look good, though.

However, they packaged and are using https://github.com/mikebrady/shairport-sync client, which works well with PulseAudio, which we do have here: https://github.com/openwrt/packages/blob/56e29ed7daf39b683be49f06cb4bc065b2bdfd35/sound/shairport-sync/Makefile

@BKPepe
Copy link
Member

BKPepe commented Nov 6, 2023

I see that in the past @Noltari added and was using this package. Are you still using this or do you know some better alternatives?

@neheb
Copy link
Contributor Author

neheb commented Nov 6, 2023

@Ansuel it’s broken already. No need to keep on life support

This package is not only abandoned upstream, it has not worked with iOS
versions since at least 2019:

juhovh/shairplay#80

Signed-off-by: Rosen Penev <rosenp@gmail.com>
It seems this is meant for distributions that lack mdnsresponder. It's
heavier than it as dbus is required.

Since this happens to conflict with mdnsresponder, just remove it.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
@neheb
Copy link
Contributor Author

neheb commented Nov 17, 2023

@Ansuel merging soon if no objections. I want openthread-br built on the buildbots.

@Ansuel
Copy link
Member

Ansuel commented Nov 17, 2023

Ok for me.

@neheb neheb merged commit 5ae88c4 into openwrt:master Nov 17, 2023
12 checks passed
@neheb neheb deleted the comp branch November 17, 2023 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants