Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

golang: update to 1.22.1 #23475

Merged
merged 2 commits into from
Mar 21, 2024
Merged

golang: update to 1.22.1 #23475

merged 2 commits into from
Mar 21, 2024

Conversation

mochaaP
Copy link
Contributor

@mochaaP mochaaP commented Feb 19, 2024

Maintainer: @jefferyto
Compile tested: aarch64_cortex-a53 @ SNAPSHOT
Run tested: x86_64-generic @ SNAPSHOT

Description:
Updated to go 1.22.1

Added a third bootstrap stage (go1.21.5, the last known-good build), since go1.22 (and onwards) requires at least go1.20.14 to build.1

Fixes: #23541

Footnotes

  1. https://go.dev/doc/go1.22#bootstrap

@predators46
Copy link
Contributor

I like this. tested openwrt 21.02.7

@predators46
Copy link
Contributor

predators46 commented Feb 27, 2024

@mochaaP

the problem occurs if building the sing-box package using openwrt-sdk. but if you build sing-box on the device after installing the golang package on openwrt sing-box can be made

-linkmode requires external (cgo) linking, but cgo is not enabled

@mochaaP
Copy link
Contributor Author

mochaaP commented Feb 27, 2024

@mochaaP

the problem occurs if building the sing-box package using openwrt-sdk. but if you build sing-box on the device after installing the golang package on openwrt sing-box can be made

-linkmode requires external (cgo) linking, but cgo is not enabled

You need CGO_ENABLED=1

@predators46
Copy link
Contributor

the problem is in the Makefile I am using. now everything is running smoothly

@mochaaP
Copy link
Contributor Author

mochaaP commented Feb 27, 2024

cc @1715173329 do you have time to rebuild world with this?

@BKPepe
Copy link
Member

BKPepe commented Feb 29, 2024

I like this. tested openwrt 21.02.7

Are you sure with this OpenWrt version? This needs to be compile and run tested for the master branch. Not on deprecated and already end of life branch.

@predators46
Copy link
Contributor

I like this. tested openwrt 21.02.7

Are you sure with this OpenWrt version? This needs to be compile and run tested for the master branch. Not on deprecated and already end of life branch.

I like this. tested openwrt 21.02.7

Are you sure with this OpenWrt version? This needs to be compile and run tested for the master branch. Not on deprecated and already end of life branch.

I have tried openwrt 23.05.2. the master branch should have no problems

@mochaaP mochaaP changed the title golang: update to 1.22.0 golang: update to 1.22.1 Mar 8, 2024
@predators46
Copy link
Contributor

version go1.22.1.src.tar.gz
bootstrap version go1.20.14.src.tar.gz

all in all no problem when building golang packages

lang/golang/golang/Makefile Outdated Show resolved Hide resolved
@BKPepe
Copy link
Member

BKPepe commented Mar 10, 2024

Commit with the update 1.22.1 isnt sufficient, because you are missing commit description. Please take a look at the Git history, how @jefferyto and others were doing it.

@mochaaP
Copy link
Contributor Author

mochaaP commented Mar 10, 2024

@BKPepe:

Commit with the update 1.22.1 isnt sufficient, because you are missing commit description.

Done. 7ce9df6 (#23475)

@xh0823
Copy link

xh0823 commented Mar 20, 2024

When can it be merged? Is there any error?

@1715173329
Copy link
Member

As an old man I still vote to use go 1.20 for bootstrap, otherwise LGTM. @jefferyto might be on vacation?

Added a third bootstrap stage since go1.22 (and onwards) requires
at least go1.20.14 to build.[1]

[1]: https://go.dev/doc/go1.22#bootstrap

Signed-off-by: Zephyr Lykos <git@mochaa.ws>
Go 1.22.1 contains the following security fixes:

- CVE-2024-24783:
  crypto/x509: Verify panics on certificates with an unknown public key
  algorithm
- CVE-2023-45290
  net/http: memory exhaustion in Request.ParseMultipartForm
- CVE-2023-45289
  net/http, net/http/cookiejar: incorrect forwarding of sensitive headers
  and cookies on HTTP redirect
- CVE-2024-24785
  html/template: errors returned from MarshalJSON methods may break
  template escaping
- CVE-2024-24784
  net/mail: comments in display names are incorrectly handled

https://go.dev/doc/devel/release#go1.22.1
https://groups.google.com/g/golang-announce/c/5pwGVUPoMbg

Signed-off-by: Zephyr Lykos <git@mochaa.ws>
@1715173329
Copy link
Member

Okay I would like to merge this in 24 hours if there's no further comments.

@1715173329 1715173329 merged commit 6aa843b into openwrt:master Mar 21, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Goland (go) update
5 participants