-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
golang: update to 1.22.1 #23475
golang: update to 1.22.1 #23475
Conversation
2ad7dd1
to
bed91a8
Compare
I like this. tested openwrt 21.02.7 |
the problem occurs if building the sing-box package using openwrt-sdk. but if you build sing-box on the device after installing the golang package on openwrt sing-box can be made
|
You need |
the problem is in the Makefile I am using. now everything is running smoothly |
cc @1715173329 do you have time to rebuild world with this? |
Are you sure with this OpenWrt version? This needs to be compile and run tested for the master branch. Not on deprecated and already end of life branch. |
I have tried openwrt 23.05.2. the master branch should have no problems |
version go1.22.1.src.tar.gz all in all no problem when building golang packages |
Commit with the update 1.22.1 isnt sufficient, because you are missing commit description. Please take a look at the Git history, how @jefferyto and others were doing it. |
Done. |
When can it be merged? Is there any error? |
As an old man I still vote to use go 1.20 for bootstrap, otherwise LGTM. @jefferyto might be on vacation? |
Added a third bootstrap stage since go1.22 (and onwards) requires at least go1.20.14 to build.[1] [1]: https://go.dev/doc/go1.22#bootstrap Signed-off-by: Zephyr Lykos <git@mochaa.ws>
Go 1.22.1 contains the following security fixes: - CVE-2024-24783: crypto/x509: Verify panics on certificates with an unknown public key algorithm - CVE-2023-45290 net/http: memory exhaustion in Request.ParseMultipartForm - CVE-2023-45289 net/http, net/http/cookiejar: incorrect forwarding of sensitive headers and cookies on HTTP redirect - CVE-2024-24785 html/template: errors returned from MarshalJSON methods may break template escaping - CVE-2024-24784 net/mail: comments in display names are incorrectly handled https://go.dev/doc/devel/release#go1.22.1 https://groups.google.com/g/golang-announce/c/5pwGVUPoMbg Signed-off-by: Zephyr Lykos <git@mochaa.ws>
Okay I would like to merge this in 24 hours if there's no further comments. |
Maintainer: @jefferyto
Compile tested:
aarch64_cortex-a53
@ SNAPSHOTRun tested:
x86_64-generic
@ SNAPSHOTDescription:
Updated to go 1.22.1
Added a third bootstrap stage (go1.21.5, the last known-good build), since go1.22 (and onwards) requires at least go1.20.14 to build.1
Fixes: #23541
Footnotes
https://go.dev/doc/go1.22#bootstrap ↩