irqbalance: Update init script to remove duplicate spaces #23557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why are the checks failing? |
schuettecarsten
changed the title
|
Missing |
|
Please format your commits, thanks! |
schuettecarsten
force-pushed
the
patch-1
branch
2 times, most recently
from
a0eeae4
to
e0c9438
Compare
Done. |
BKPepe
reviewed
Mar 5, 2024
1715173329
requested changes
Mar 6, 2024
|
cc @hnyman for review |
|
@1715173329 - updated commit message and make use of procd_append_param for parameters, also added check for default values. There might be more options to optimize this... Please note that I've added a new debug configuration parameter, the patch for luci will follow after this PR was merged. |
1715173329
reviewed
Mar 7, 2024
I have some strange issues with irqbalance sometimes overwritin smp_affinity values for banned/ignored IRQs. The issue is reproduceable and is mitigated when I change theway how the irqbalance command line is built. The only difference between the resulting command is that there is only one space between the -t parameter and the first -i parameter value. Also see Irqbalance/irqbalance#297 Signed-off-by: Carsten Schuette <schuettecarsten@googlemail.com>
|
Thank you for merging, the luci patch is available at openwrt/luci#6971 |
|
Merged ;-) |
1715173329
reviewed
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have some strange issues with irqbalance sometimes overwriting smp_affinity values for banned/ignored IRQs. The issue is reproduceable and is mitigated when I change theway how the irqbalance command line is built. The only difference between the resulting command is that there is only one space between the -t parameter and the first -i parameter value.