Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

knot: fix EXTRA_DEPENDS release versions #24059

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

facboy
Copy link

@facboy facboy commented May 1, 2024

Maintainer: @Payne-X6

Build system: x86/64
Compile tested: rockchip/armv8, nanopi-r4s, be37ab6 snapshot build
Run tested: rockchip/armv8, nanopi-r4s, be37ab6 snapshot build, running on my main router

Description: EXTRA_DEPENDS now requires an r before the PKG_RELEASE because of
openwrt/openwrt@e8725a9.

Fixes #23735

@BKPepe
Copy link
Member

BKPepe commented May 1, 2024

In the commit description - there should be why, it needs now to have there "r" in EXTRA_DEPENDS and most likely also the Fixes tag.

@facboy
Copy link
Author

facboy commented May 1, 2024

like so?

@trippleflux
Copy link

There is typo in define Package/knot-keymgr, should be :

define Package/knot-keymgr
	$(call Package/knot/Default)
	TITLE+= DNSSEC key management utility
	DEPENDS+=+libedit +liburcu +knot-libs +knot-libzscanner
	EXTRA_DEPENDS:=knot-libs (=$(PKG_VERSION)-r$(PKG_RELEASE)), \
	               knot-libzscanner (=$(PKG_VERSION)-r$(PKG_RELEASE))
endef

@facboy
Copy link
Author

facboy commented May 5, 2024

ah thanks, fixed.

EXTRA_DEPENDS now requires an `r` before the `PKG_RELEASE` because of
openwrt/openwrt@e8725a9.

Fixes openwrt#23735

Signed-off-by: Christopher Ng <facboy@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to configuring knot package
3 participants