pcre: small makefile fixes #274
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- make license tag spdx conform - drop duplicate copy commands (previous lines with asterisk match already) - minor whitespace cleanup Signed-off-by: Michael Heimpold <mhei@heimpold.de>
| endef | ||
|
|
||
| define Package/libpcrecpp/install | ||
| $(INSTALL_DIR) $(1)/usr/lib | ||
| $(CP) $(PKG_INSTALL_DIR)/usr/lib/libpcrecpp.so.* $(1)/usr/lib/ | ||
| $(CP) $(PKG_INSTALL_DIR)/usr/lib/libpcrecpp.so* $(1)/usr/lib/ |
There was a problem hiding this comment.
isn't .so for debug and .so.* for normal use?
There was a problem hiding this comment.
I don't think so. According to http://tldp.org/HOWTO/Program-Library-HOWTO/shared-libraries.html:
Thus, /usr/lib/libreadline.so.3 is a fully-qualified soname, which ldconfig would set to be a symbolic link to some
realname like /usr/lib/libreadline.so.3.0. There should also be a linker name, /usr/lib/libreadline.so which could
be a symbolic link referring to /usr/lib/libreadline.so.3.
my understanding is, that such symbolic links should be present.
|
The .so symlink is the the linker name, it is only used by the compiler/linker and is not needed on nondevel systems. |
|
Ok, in this case, this patch chunk makes things even worse by polluting the root filesystems with unneeded links. |
mhei
added a commit
that referenced
this pull request
Sep 5, 2014
The .so symlinks (without any suffix) are only used by compiler/linker and not needed on the target system. See #274 for a short discussion. Signed-off-by: Michael Heimpold <mhei@heimpold.de>
|
Will file a new PR with this issue resolved. |
thess
pushed a commit
to thess/OpenWrt-packages
that referenced
this pull request
Sep 17, 2014
The .so symlinks (without any suffix) are only used by compiler/linker and not needed on the target system. See openwrt#274 for a short discussion. Signed-off-by: Michael Heimpold <mhei@heimpold.de>
dajhorn
added a commit
to dajhorn/openwrt-packages
that referenced
this pull request
Jun 10, 2017
From the upstream NEWS file: v1.7.5 lz4hc : new high compression mode : levels 10-12 compress more and slower, by Przemyslaw Skibinski lz4cat : fix : works with relative path (openwrt#284) and stdin (openwrt#285) (reported by @beiDei8z) cli : fix minor notification when using -r recursive mode API : lz4frame : LZ4F_frameBound(0) gives upper bound of *flush() and *End() operations (openwrt#290, openwrt#280) doc : markdown version of man page, by Takayuki Matsuoka (openwrt#279) build : Makefile : fix make -jX lib+exe concurrency (openwrt#277) build : cmake : improvements by Michał Górny (openwrt#296) v1.7.4.2 fix : Makefile : release build compatible with PIE and customized compilation directives provided through environment variables (openwrt#274, reported by Antoine Martin) v1.7.4 Improved : much better speed in -mx32 mode cli : fix : Large file support in 32-bits mode on Mac OS-X fix : compilation on gcc 4.4 (openwrt#272), reported by Antoine Martin v1.7.3 Changed : moved to versioning; package, cli and library have same version number Improved: Small decompression speed boost Improved: Small compression speed improvement on 64-bits systems Improved: Small compression ratio and speed improvement on small files Improved: Significant speed boost on ARMv6 and ARMv7 Fix : better ratio on 64-bits big-endian targets Improved cmake build script, by Evan Nemerson New liblz4-dll project, by Przemyslaw Skibinki Makefile: Generates object files (*.o) for faster (re)compilation on low power systems cli : new : --rm and --help commands cli : new : preserved file attributes, by Przemyslaw Skibinki cli : fix : crash on some invalid inputs cli : fix : -t correctly validates lz4-compressed files, by Nick Terrell cli : fix : detects and reports fread() errors, thanks to Hiroshi Fujishima report openwrt#243 cli : bench : new : -r recursive mode lz4cat : can cat multiple files in a single command line (openwrt#184) Added : doc/lz4_manual.html, by Przemyslaw Skibinski Added : dictionary compression and frame decompression examples, by Nick Terrell Added : Debianization, by Evgeniy Polyakov Signed-off-by: Darik Horn <dajhorn@vanadac.com>
jp-bennett
pushed a commit
to jp-bennett/packages
that referenced
this pull request
Jul 29, 2017
From the upstream NEWS file: v1.7.5 lz4hc : new high compression mode : levels 10-12 compress more and slower, by Przemyslaw Skibinski lz4cat : fix : works with relative path (openwrt#284) and stdin (openwrt#285) (reported by @beiDei8z) cli : fix minor notification when using -r recursive mode API : lz4frame : LZ4F_frameBound(0) gives upper bound of *flush() and *End() operations (openwrt#290, openwrt#280) doc : markdown version of man page, by Takayuki Matsuoka (openwrt#279) build : Makefile : fix make -jX lib+exe concurrency (openwrt#277) build : cmake : improvements by Michał Górny (openwrt#296) v1.7.4.2 fix : Makefile : release build compatible with PIE and customized compilation directives provided through environment variables (openwrt#274, reported by Antoine Martin) v1.7.4 Improved : much better speed in -mx32 mode cli : fix : Large file support in 32-bits mode on Mac OS-X fix : compilation on gcc 4.4 (openwrt#272), reported by Antoine Martin v1.7.3 Changed : moved to versioning; package, cli and library have same version number Improved: Small decompression speed boost Improved: Small compression speed improvement on 64-bits systems Improved: Small compression ratio and speed improvement on small files Improved: Significant speed boost on ARMv6 and ARMv7 Fix : better ratio on 64-bits big-endian targets Improved cmake build script, by Evan Nemerson New liblz4-dll project, by Przemyslaw Skibinki Makefile: Generates object files (*.o) for faster (re)compilation on low power systems cli : new : --rm and --help commands cli : new : preserved file attributes, by Przemyslaw Skibinki cli : fix : crash on some invalid inputs cli : fix : -t correctly validates lz4-compressed files, by Nick Terrell cli : fix : detects and reports fread() errors, thanks to Hiroshi Fujishima report openwrt#243 cli : bench : new : -r recursive mode lz4cat : can cat multiple files in a single command line (openwrt#184) Added : doc/lz4_manual.html, by Przemyslaw Skibinski Added : dictionary compression and frame decompression examples, by Nick Terrell Added : Debianization, by Evgeniy Polyakov Signed-off-by: Darik Horn <dajhorn@vanadac.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Michael Heimpold mhei@heimpold.de