procps-ng: fix build on systems without gettext development utilities #2893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current procps-ng Makefile calls the shipped autogen.sh script which
introduces incorrect implicit dependencies on host utilities, leading to
the following error observed on a minimal build system:
(cd .../procps-ng-3.3.11; echo "3.3.11" > ".../procps-ng-3.3.11/.tarball-version"; ./autogen.sh );
You must have autopoint installed to generate procps-ng build system.
The autopoint command is part of the GNU gettext package.
Makefile:96: recipe for target '.../procps-ng-3.3.11/.configured_yynyyyyy' failed
make[3]: *** [.../procps-ng-3.3.11/.configured_yynyyyyy] Error 1
Apply the following changes in order to fix compilation:
- Apply the generic autoreconf fixup to generate configure and Makefiles
- Use Build/Prepare to populate .tarball-version and revert Build/Configure
to its default implementation
- Disable to build of docs and tests as those require additional utilities
not guaranteed to be present
Fixes openwrt#2890.
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
|
Works for me, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current procps-ng Makefile calls the shipped autogen.sh script which
introduces incorrect implicit dependencies on host utilities, leading to
the following error observed on a minimal build system:
Apply the following changes in order to fix compilation:
to its default implementation
not guaranteed to be present
Fixes #2890.
Signed-off-by: Jo-Philipp Wich jo@mein.io