Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ttyd: new package #3244

Merged
merged 1 commit into from Sep 28, 2016
Merged

ttyd: new package #3244

merged 1 commit into from Sep 28, 2016

Conversation

tsl0922
Copy link
Contributor

@tsl0922 tsl0922 commented Sep 27, 2016

Maintainer: me
Compile tested: (ramips, PSG1208, LEDE HEAD, r1656)
Run tested: (ramips, PSG1208, LEDE HEAD, r1656)

Description:

Add ttyd package

Signed-off-by: Shuanglei Tao tsl0922@gmail.com

@tsl0922 tsl0922 changed the title Add ttyd package ttyd: new package Sep 27, 2016
@diizzyy
Copy link
Contributor

diizzyy commented Sep 27, 2016

Please change copyright disclaimer to your own name instead of openwrt.

$(INSTALL_BIN) ./files/ttyd.init $(1)/etc/init.d/ttyd
endef

$(eval $(call BuildPackage,ttyd))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs EOL

Copy link
Contributor Author

@tsl0922 tsl0922 Sep 27, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thess done

stop
sleep 2 # give time to shutdown
start
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs EOL

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@thess
Copy link
Member

thess commented Sep 27, 2016

@diizzyy - Are you saying package Makefiles and files should be copyright by the submitter and not the organization(s) involved? That is certainly not what we've been doing all along. Why do you suggest this change?

BTW @tsl0922 - The copyright date needs to be updated.

@tsl0922
Copy link
Contributor Author

tsl0922 commented Sep 27, 2016

EDIT: changed to Copyright (C) 2014-2016 OpenWrt.org

@thess Can you give me the full copyright text I should put at the top? Thanks.

@diizzyy
Copy link
Contributor

diizzyy commented Sep 27, 2016

@thess
Unless you're under contract by OpenWRT there's no point in putting anything else than your own.
"An up-to-date copyright notice. Use OpenWrt if no other present or supply your own." This is also the course LEDE follows, https://www.lede-project.org/faq.html (a bit down).

@thess
Copy link
Member

thess commented Sep 27, 2016

Seems to me from that statement, either is OK. No need to force a change if author doesn't want to.

@tsl0922 - Since this is a new package either...

# Copyright (C) 2016 OpenWrt.org
or
# Copyright (C) 2016 Shuanglei Tao <tsl0922@gmail.com>

would be fine.

@diizzyy
Copy link
Contributor

diizzyy commented Sep 27, 2016

Preferably would be your own but oh well, I should have phrased myself better.

Signed-off-by: Shuanglei Tao <tsl0922@gmail.com>
@tsl0922
Copy link
Contributor Author

tsl0922 commented Sep 27, 2016

Updated to myself since this may makes it more easily to find my contact information from the Makefile, @diizzyy @thess

@thess thess merged commit 0a1fcfc into openwrt:master Sep 28, 2016
@tsl0922 tsl0922 deleted the ttyd branch September 28, 2016 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants