wireguard-tools: add netifd protocol helper #3512
Conversation
Signed-off-by: Dan Lüdtke <mail@danrl.com>
Signed-off-by: Dan Lüdtke <mail@danrl.com>
|
FYI: LuCi pull request is over here: openwrt/luci#848 |
|
Thanks for the pull request. I was actually testing your script this afternoon, but apparently a bit too late :) General comments are in https://github.com/danrl/luci-proto-wireguard/issues/5 Regarding the pull request, you can merge the two commits. Also, can you add |
| # ensure endpoint reachability | ||
| if [ "${endpoint_host}" ]; then | ||
| added_dependency="false" | ||
| for ip in $(resolveip -t 5 "${endpoint_host}"); do |
There was a problem hiding this comment.
Last I checked, resolveip requires a separate package. If this bit of logic is actually needed in the code, then probably the makefile should depend on having that package. I hit this snag twice when setting up my OpenWRT router a few days ago. The first time I just removed this block, and things worked fine. The second time I just installed resolveip, and things worked fine. Probably @zorun is the right man to make the call on what to do.
There was a problem hiding this comment.
Unfortunately, yes, it is needed. Dependency is required for tunnels that add a default route. It is said to take care of creating a route to the endpoint(s) so they remain reachable in case of a new default route (if one endpoint has allowed_ips ::/0 and we create a route for ::/0 through the wg interface).
| @@ -10,7 +10,7 @@ include $(INCLUDE_DIR)/kernel.mk | |||
| PKG_NAME:=wireguard | |||
|
|
|||
| PKG_VERSION:=0.0.20161105 | |||
There was a problem hiding this comment.
This might as well be bumped, while we're at it.
|
Will PR with updated version. This one is closed. |
Maintainer: Baptiste Jonglez @zorun
Run tested: OpenWRT snapshot Nov 11 2016 x86
Description: Helper script for upcoming luci-proto-wireguard