Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upwireguard-tools: add netifd protocol helper #3512
Conversation
danrl
added some commits
Nov 13, 2016
danrl
referenced this pull request
Nov 13, 2016
Closed
luci-proto-wireguard: WireGuard VPN Protocol (New) #848
This comment has been minimized.
This comment has been minimized.
|
FYI: LuCi pull request is over here: openwrt/luci#848 |
This comment has been minimized.
This comment has been minimized.
zorun
commented
Nov 13, 2016
|
Thanks for the pull request. I was actually testing your script this afternoon, but apparently a bit too late :) General comments are in https://github.com/danrl/luci-proto-wireguard/issues/5 Regarding the pull request, you can merge the two commits. Also, can you add |
zx2c4
reviewed
Nov 13, 2016
| # ensure endpoint reachability | ||
| if [ "${endpoint_host}" ]; then | ||
| added_dependency="false" | ||
| for ip in $(resolveip -t 5 "${endpoint_host}"); do |
This comment has been minimized.
This comment has been minimized.
zx2c4
Nov 13, 2016
Contributor
Last I checked, resolveip requires a separate package. If this bit of logic is actually needed in the code, then probably the makefile should depend on having that package. I hit this snag twice when setting up my OpenWRT router a few days ago. The first time I just removed this block, and things worked fine. The second time I just installed resolveip, and things worked fine. Probably @zorun is the right man to make the call on what to do.
This comment has been minimized.
This comment has been minimized.
danrl
Nov 14, 2016
Author
Contributor
Unfortunately, yes, it is needed. Dependency is required for tunnels that add a default route. It is said to take care of creating a route to the endpoint(s) so they remain reachable in case of a new default route (if one endpoint has allowed_ips ::/0 and we create a route for ::/0 through the wg interface).
zx2c4
reviewed
Nov 13, 2016
| @@ -10,7 +10,7 @@ include $(INCLUDE_DIR)/kernel.mk | |||
| PKG_NAME:=wireguard | |||
|
|
|||
| PKG_VERSION:=0.0.20161105 | |||
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Will PR with updated version. This one is closed. |
danrl commentedNov 13, 2016
Maintainer: Baptiste Jonglez @zorun
Run tested: OpenWRT snapshot Nov 11 2016 x86
Description: Helper script for upcoming luci-proto-wireguard