Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sqm-scripts & luci-app-sqm: experimental QoS #433

Merged
merged 2 commits into from Oct 15, 2014

Conversation

hnyman
Copy link
Contributor

@hnyman hnyman commented Oct 15, 2014

sqm-scripts is a new QoS system from Cerowrt / Bufferbloat.
I have tested it in my own community build.

This pull request contains both the sqm-scripts itself and also the Luci GUI to manage it.
Both packages are added to /net

More info at:
http://www.bufferbloat.net/projects/cerowrt/wiki/Smart_Queue_Management
http://www.bufferbloat.net/projects/cerowrt/wiki/Setting_up_SQM_for_CeroWrt_310

Dave Täht submitted this first via openwrt-devel mailing list in March 2014,
but that was not picked up before the switch to Github:
http://patchwork.openwrt.org/patch/5078/

I have modified:

Signed-off-by: Hannu Nyman hannu.nyman@iki.fi

sqm-scripts is a new QoS system from Cerowrt / Bufferbloat.
I have tested it in my own community build.

More info at:
http://www.bufferbloat.net/projects/cerowrt/wiki/Smart_Queue_Management
http://www.bufferbloat.net/projects/cerowrt/wiki/Setting_up_SQM_for_CeroWrt_310

Dave Täht submitted this first via openwrt-devel mailing list in March 2014,
but that was not picked up before the switch to Github:
http://patchwork.openwrt.org/patch/5078/

Original code used as the base:
dtaht/ceropackages-3.10@8ce2936

I have modified:
- set the default interface to be eth1, like the Openwrt default.
- modified config to hide some of the advanced options by default
- beautified Makefile a bit
- added Toke Høiland-Jørgensen <toke@toke.dk> as the maintainer, as discussed
  in dtaht/ceropackages-3.10#8 (comment)

Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
This is the Luci GUI for managing SQM QoS System.

Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
tohojo added a commit that referenced this pull request Oct 15, 2014
Add sqm-scripts & luci-app-sqm: experimental QoS
@tohojo tohojo merged commit 8936f22 into openwrt:master Oct 15, 2014
@hnyman hnyman deleted the add-sqm-scripts branch October 15, 2014 17:24
@sbyx
Copy link
Member

sbyx commented Oct 15, 2014

Please add some sort of copyright, (minimal?) license info to the shell scripts and PKG_LICENSE tags to both makefiles.

@tohojo
Copy link
Contributor

tohojo commented Oct 15, 2014

Please add some sort of copyright, (minimal?) license info to the shell scripts
and PKG_LICENSE tags to both makefiles.

Ah yes; added the PKG_LICENSE tags, will make sure the shell files grow
some license headers as well... :)

-Toke

@hnyman
Copy link
Contributor Author

hnyman commented Oct 15, 2014

Sorry about forgetting about the LICENSE tag.

But I wonder about request about copyright & license info in the actual shell scripts. Is that really typical? E.g. qos-scripts has copyright similarly only on Makefile and scripts are pure scripts.

But maybe this is different, as the scripts are originating at cerowrt/bufferbloat.

@sbyx
Copy link
Member

sbyx commented Oct 15, 2014

Well yeah the Makefile says (c) OpenWrt.org and its the only copyright statement so far, so I guess it would be fair to add at least some minimal headers with the original authors to the shell scripts.

champtar pushed a commit to champtar/packages that referenced this pull request Jul 7, 2019
luci-app-bmx6: Fix URL of network topology JSON file
Fanfwe pushed a commit to Fanfwe/packages that referenced this pull request Aug 18, 2021
Fanfwe pushed a commit to Fanfwe/packages that referenced this pull request Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants