python,python3: minor build improvements #4538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems it's called underlinking that's happening only on Ubuntu 12.04 with libressl (that comes from LEDE's tools folder). Link here: https://ubuntuforums.org/showthread.php?t=1870586 I'm still reading about this a bit. Since I don't really get it. But applying that fix (as in the link) seems to fix compiling on Ubuntu 12.04, and tried also on 16.04 (to make sure). Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com>
A suggestion from comment (from Philip Prindeville): openwrt#4529 (comment) Avoids some escaping of slashes. Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com>
…ols & pip If you build python/python3 and later decide to build python(3)-setuptools and/or python(3)-pip, the build won't re-run without adding `CONFIG_PACKAGE_python(3)-setuptools` and `CONFIG_PACKAGE_python(3)-pip`. Seems to resolve issue: openwrt#4529 Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com>
|
LGTM, merged :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maintainer: me
Compile tested: lede-project/source@23da3fb
Run tested: N/A
Description:
sedexpression used in python-setupools/pip packages ; python-setuptools: Does not compile #4529 (comment)Signed-off-by: Alexandru Ardelean ardeleanalex@gmail.com