ffmpeg: update to 3.2.6, correct arm optimization check #4555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpfu=neon implies neon-vfpv3, so enable vfp when just neon is found. Signed-off-by: Ian Leonard <antonlacon@gmail.com>
|
Thanks, is there a reason why we're not using the 3.3 branch? |
|
No special reason not to use 3.3. It hasn't been a priority for me. |
|
@hnyman |
|
@antonlacon |
jp-bennett
pushed a commit
to jp-bennett/packages
that referenced
this pull request
Jul 29, 2017
Update mpg123 to 1.25.2 Change download URL to Sourceforge Change deprecated checksum variable (PKG_MD5SUM) to PKG_HASH Add libout123 Add generic optimizations depending on platform have fpu or not Add NEON-specific optimization Remove BUILD_PATENTED, reference: openwrt#4587 Small cleanup of Makefile Thanks to Ted Hess for reviewing and suggesting compilation fix NOTE: mpg123 uses the most recent approach just like ffmpeg that's mentioned here: openwrt#4555 Signed-off-by: Daniel Engberg <daniel.engberg.lists@pyret.net>
mkrkn
pushed a commit
to mkrkn/packages
that referenced
this pull request
Aug 23, 2017
Update mpg123 to 1.25.2 Change download URL to Sourceforge Change deprecated checksum variable (PKG_MD5SUM) to PKG_HASH Add libout123 Add generic optimizations depending on platform have fpu or not Add NEON-specific optimization Remove BUILD_PATENTED, reference: openwrt#4587 Small cleanup of Makefile Thanks to Ted Hess for reviewing and suggesting compilation fix NOTE: mpg123 uses the most recent approach just like ffmpeg that's mentioned here: openwrt#4555 Signed-off-by: Daniel Engberg <daniel.engberg.lists@pyret.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maintainer: me & @thess
Compile tested: mvebu/wrt3200acm, imx6/generic, LEDE trunk
Run tested: none
Description:
Minor version bump of ffmpeg to 3.2.6 and correct issue #4506
The arm optimization check is changed to be roughly:
if vfp found in target optimizations, then enable vfp, otherwise disable vfp.
then check if neon is in target optimizations and enable vfp & neon, otherwise disable neon.
As ffmpeg takes the "most recent" enable/disable command as the one to use, enabling vfp with neon effectively bypasses the earlier vfp check disabling it when not found. I don't have the hardware to test deployment, but ./configure does what I expect it to on the vfp-only and neon+vfp boards compiled for above.