transmission: CONFIG_LIBCURL_ZLIB must be enabled for http announce

[V-E-O]

Maintainer: me
Compile tested: LEDE 17.01.2
Run tested: Broadcom BCM47xx/53xx (ARM) device
Description:
When TR does http announce, libcurl is set with accept GZIP encoding, https://github.com/transmission/transmission/blob/2.92/libtransmission/web.c#L183
. So CONFIG_LIBCURL_ZLIB must be selected or http annouce GZIP response will cause error.

Signed-off-by: VYSE V.E.O VEO@LIVE.COM

[hnyman]

maintainer is @obsy

But the fix looks wrong to me, as this would change all libcurl compilations (also in buildbot, I think).

Transmission should not change another package's build config.

[V-E-O]

@hnyman I think it's only dependency config that Transmission should be built with a libcurl zlib enabled, or users may be noticed to tick both transmission and library->curl->enable zlib every menuconfig.
This CONFIG_LIBCURL_ZLIB was option to generate target arch package libcurl.so with zlib, not affecting buildbot.

[champtar]

Hi @V-E-O

I agree with @hnyman, we cannot accept +@LIBCURL_ZLIB as LIBCURL_ZLIB defaults to no, and this will silently change the default when doing a build of all packages (like the buildbots are doing)

You can try (but I don't think you will succeed) to convince people to:

• enable LIBCURL_ZLIB by default
• have 2 versions of libcurl (libcurl-zlib or libcurl-full)

Else you can put a dependency on @LIBCURL_ZLIB (without the +) which means transmission will not be built anymore by the buildbots (which I'm not convince is a good solution)

The only realistic solution for me is to patch transmission to not advertise GZIP support when it's not supported

[cfpp2p]

transmission/transmission#495 (comment)

[V-E-O]

Same issue like this one #5459

Wait for if TR accept removing the default requirement of ZLIB.

[hnyman]

closing due to #5560 and the upstream transmission changes mentioned above.