-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
treewide: start logger at priority 12 #4818
Conversation
Hi @pprindeville |
It's not, it's at 20. And that's the point. We want logging run before the network comes up. If the network fails to come up, we need some place to capture information (logs) about why. |
I misunderstood your comment, then why not less than 12? (add a small explanation in the commit, we want to be as early as possible but after X) |
@@ -1,7 +1,7 @@ | |||
#!/bin/sh /etc/rc.common | |||
# Copyright (C) 2006-2016 OpenWrt.org | |||
|
|||
START=20 | |||
START=12 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
imho neither 12 nor 20 make sense here. 41 would be appropriate, as that's the point where we are supposed to have mounted everything syslog-ng might be writing to
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/var
is a link to /tmp
, so that gets mounted early on.
We could always add triggers so that if the network configuration changes or the filesystem changes that it gets reloaded...
@@ -1,7 +1,7 @@ | |||
#!/bin/sh /etc/rc.common | |||
# Copyright (C) 2014 OpenWrt.org | |||
|
|||
START=20 | |||
START=12 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as for syslog-ng
net/ulogd/files/ulogd.init
Outdated
@@ -1,7 +1,7 @@ | |||
#!/bin/sh /etc/rc.common | |||
# Copyright (C) 2014 OpenWrt.org | |||
|
|||
START=20 | |||
START=12 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ulogd may require to be started even much later as it may require a database server to be up and running... anyhow, it's really a different type of beast than rsyslog or syslog-ng.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, dropping ulogd from changeset.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm made the requested changes. Can we please proceed?
2ab8557
to
6968a61
Compare
Done. |
sysctl is at 11, so we want to run after that since it might affect network settings we should inherit. Signed-off-by: Philip Prindeville <philipp@redfish-solutions.com>
6968a61
to
e2e4e6c
Compare
Can we proceed without @dangowrt's approval as he seems to be MIA? |
Abandoning... 12 is too early and indeed the timezone hasn't been configured by then (because |
Maintainer: @blogic, @MikePetullo, @dubek, @psycho-nico
Compile tested: x86_64, generic, LEDE head (6be7010)
Run tested: same
Built and installed (via scp/opkg install) all three packages and tested them individually, rebooting each time.
Description:
Set
START
priority to 12 (instead of 20, same asnetwork
).