python: add __PYENV_LAUNCHER__ env var #525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mostly useful for setuptools and pip during build. Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com>
sbyx
added a commit
that referenced
this pull request
Nov 9, 2014
python: add __PYENV_LAUNCHER__ env var
jefferyto
added a commit
to jefferyto/openwrt-packages
that referenced
this pull request
May 25, 2023
Setting __PYVENV_LAUNCHER__ for Python package builds was added in a91a992, but neither the commit message nor the pull request[1] explain its purpose in detail. My guess is this was done to set the shebang for installed Python scripts. We now have a Makefile recipe to set the shabang, so setting this variable for this purpose is unnecessary. It appears that Python 3.11 has changed the handling of this (internal) environment variable, and setting it appears to be causing build errors for all Python packages. This removes setting __PYVENV_LAUNCHER__ for Python package builds. [1]: openwrt#525 Fixes: openwrt#21162 Signed-off-by: Jeffery To <jeffery.to@gmail.com>
jefferyto
added a commit
to jefferyto/openwrt-packages
that referenced
this pull request
May 25, 2023
Setting __PYVENV_LAUNCHER__ for Python package builds was added in a91a992, but neither the commit message nor the pull request[1] explain its purpose in detail. My guess is this was done to set the shebang for installed Python scripts. We now have a Makefile recipe to set the shebang, so it would be unnecessary to set this variable for this purpose. It appears that Python 3.11 has changed the handling of this (internal) environment variable, and setting it appears to be causing build errors for all Python packages. This removes setting __PYVENV_LAUNCHER__ for Python package builds. [1]: openwrt#525 Fixes: openwrt#21162 Signed-off-by: Jeffery To <jeffery.to@gmail.com>
jefferyto
added a commit
to jefferyto/openwrt-packages
that referenced
this pull request
May 26, 2023
Setting __PYVENV_LAUNCHER__ for Python package builds was added in a91a992, but neither the commit message nor the pull request[1] explain its purpose in detail. My guess is this was done to set the shebang for installed Python scripts. We now have a Makefile recipe to set the shebang, so it would be unnecessary to set this variable for this purpose. It appears that Python 3.11 has changed the handling of this (internal) environment variable, and setting it appears to be causing build errors for all Python packages. This removes setting __PYVENV_LAUNCHER__ for Python package builds. [1]: openwrt#525 Fixes: openwrt#21162 Signed-off-by: Jeffery To <jeffery.to@gmail.com> (cherry picked from commit 9e95dff)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly useful for setuptools and pip during build.
Signed-off-by: Alexandru Ardelean ardeleanalex@gmail.com