nginx: add http_sub_module #6510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ansuel
force-pushed
the
nginxfix
branch
2 times, most recently
from
e66d180
to
b228717
Compare
yousong
reviewed
Jul 18, 2018
| @@ -1,5 +1,5 @@ | |||
|
|
|||
| user root; | |||
| user nobody nogroup; | |||
There was a problem hiding this comment.
didn't want to create 2 commit for that small change but if it's a problem i will split them then...
There was a problem hiding this comment.
It's okay to have multiple commits in single pull request
Ansuel
force-pushed
the
nginxfix
branch
2 times, most recently
from
573c21f
to
45f723d
Compare
Someone requested this module to be included, so create the config flag for it. Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
|
@hnyman can you merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Someone requested this module to be included, so create the config flag for it.
@hnyman
Signed-off-by: Ansuel Smith ansuelsmth@gmail.com