libftdi: fix packagekit when useing cmake #690
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmake is missing the variable VERSION. VERSION is used in libftdi.pc.in. When other packages using a min version they fail detecting libftdi. Signed-off-by: Alexander Couzens <lynxis@fe80.eu>
|
Which packages are failing? |
|
OLA is failing to build libftdi module (open light architecture)
|
|
Thomas Jarosch applied my patch on branch libftdi-0.x |
|
Can you update the pull request with the upstream patch? |
Noltari
added a commit
that referenced
this pull request
Jan 1, 2015
Based on upstream commit by Thomas Jarosch based on Alexander's patch. More info: #690 Signed-off-by: Alexander Couzens <lynxis@fe80.eu> Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
|
Fixed with d54b357 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cmake is missing the variable VERSION. VERSION is used in libftdi.pc.in. When other packages
using a min version they fail detecting libftdi.
[Please backport this to BB]