Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
python-qrcode: add Python3 and update to 6.1 #8337
Wow, I'm curious how this could even work, because there are missing dependencies.
You need pillow for a standard installation, which isn't packaged for Python3, yet. I will look at it and until I do it, this PR will remain as draft.
There are also a two issues. First one, again according to README you can use qr binary.
Once, I have installed python-setuptools, it works.
The QR code (test.png) is created. :-)
The last one is caused by me as python-qrcode and python3-qrcode provides the same binary.
I thought I had updated my Makefiles a while back, but I think this one was left behind. I was trying to update them all to python3, but this one had dependencies that were not met.
The reason I added this package was because it is a dependency to the seafile packages. I haven't tested it outside of that, so it may need some work.
If you want to take over as maintainer, please go ahead.
referenced this pull request
Mar 18, 2019
I've opened a #8446 with just the version bump, in case this takes a while.
That was too fast and I didn't have any chance to left my comment in your pull request. If you'd ask, I could separate this pull request or edit it to just bump it the version. Because now, we did the same thing. I'm not stuck with qr binary as you would think and I want to do it as it should be.
I'm still dealing with setup.py in Pillow as it is a dependency for python-qrcode. The Python2 variant of pillow is passing as it should, but setup.py for Pillow is written so horrible that takes time for me and for now I cannot compile it as it is for Python3. I'm thinking of a few ways how to do it.
Yeah, it should be faster, but while at it, I'm learning new things and I like challenges. :-)