node: don't build on unsupported cpus, remove menu

[cotequeiroz]

Maintainer: @blogic @ianchi
Compile tested: none, tested with make menuconfig and selecting unsupported targets to ensure node package was disabled.
Run tested: none

Description:
Node does not support arc or armeb. Error message below is for mips64, but @nxhack is about to open a PR supporting it, so I'll leave it out of the list.

Usage: configure [options]

configure: error: option --dest-cpu: invalid choice: 'mips64' (choose from 'arm', 'arm64', 'ia32', 'mips', 'mipsel', 'mips64el', 'ppc', 'ppc64', 'x32', 'x64', 'x86', 'x86_64', 's390', 's390x')
Makefile:131: recipe for target '/opt/buildbot/slaves/lede-slave-tah/mips64_octeonplus/build/sdk/build_dir/target-mips64_octeonplus_64_musl/node-v8.16.0/.configured_68b329da9893e34099c7d8ad5cb9c940' failed
make[3]: *** [/opt/buildbot/slaves/lede-slave-tah/mips64_octeonplus/build/sdk/build_dir/target-mips64_octeonplus_64_musl/node-v8.16.0/.configured_68b329da9893e34099c7d8ad5cb9c940] Error 2
time: package/feeds/packages/node/compile#0.80#0.38#11.19

Moved i18 option to straight under node instead of on its own menu:

{M} node.......... Node.js is a platform built on Chrome's JavaScript runtime
[ ]   enable i18n features

instead of

{M} node.......... Node.js is a platform built on Chrome's JavaScript runtime
    Module Selection  --->

and only after entering Module Selection

[ ]   enable i18n features

This does not change the package for platforms where build was working, so PKG_RELEASE was left untouched.

Signed-off-by: Eneas U de Queiroz cote2004-github@yahoo.com

[nxhack]

Hi @cotequeiroz
I am creating a patch that supports mips64. build well. I want to merge patch.

https://github.com/nxhack/openwrt-node-packages/blob/master/node/patches/v8.x/015-mips64_support.patch

[cotequeiroz]

Have you run-tested it? Building well is one thing, running well is another thing. I know V8 has code for both mips64 and mips64el, and mips64el support was added just like you're adding mips64, but it seems odd that they only enabled mips64el.
Go ahead and open a PR with your patch. Even if you can't run-test it (I'm just assuming you don't have the hardware to test it), opening a PR gives a chance for other people to do it. I will keep this open for now, but should close it if this is resolved.
Edit: If you want me to just add your patch here, I can do that as well.

[nxhack]

I have no target machine. However, the architecture of the generated binary looks correct.
I will send a PR of mips64 support. But now I am a little busy so I will send it later.

[cotequeiroz]

I'll remove mips64 from the list, so the error keeps showing up as a reminder that work needs to be done, and merge this, if you're OK with it.

[nxhack]

No problem. Please merge.

@!arc @!armeb

LGTM