mosquitto: backport upstream patches to fix compilation #9243
Conversation
Fix compilation problems by backporting two upstream commits. Patches fix the glibc detection related compilation problems (and random number generation with glibc and without TLS). Reference to issue openwrt#9005 Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
|
Note that this patch seems wrong too. It compiles but musl itself has getrandom support since version 1.1.20. The proper solution is probably to check it in the configure script. |
|
next release of mosquitto was meant to be on friday, has been pushed out due to eclipse issues internally. changelog is already available, should be tomorrow latest, There's a bunch of other fixes, not just these two, so I hadn't really seen any point in trying to bump it along, though I was expecting this dot release from upstream almost two weeks ago... @neheb, if you have concerns with the patch, please take it up with upstream directly. |
|
In any case, this should be backported to 19.07 as it fails there. Note that TurrisOS uses mosquitto by default. |
Well, mosquitto 1.6.3 has now been tagged... https://github.com/eclipse/mosquitto/releases I will close this PR as I assume that @karlp will likely issue the version bump instead. |
|
yes, I started builds for 1907 and master this afternoon when it came out. I'll finish them tomorrow. |
Fixes multiple issues, primarily of interest to OpenWrt: * getrandom issues with and without TLS and glibc See #9005 and #9243 Many many many other fixes related to mqttv5/v3.1.1 interactions and mqtt5 support options. Full changelog at: https://mosquitto.org/blog/2019/06/version-1-6-3-released/ Signed-off-by: Karl Palsson <karlp@etactica.com>
Fixes multiple issues, primarily of interest to OpenWrt: * getrandom issues with and without TLS and glibc See #9005 and #9243 Many many many other fixes related to mqttv5/v3.1.1 interactions and mqtt5 support options. Full changelog at: https://mosquitto.org/blog/2019/06/version-1-6-3-released/ Signed-off-by: Karl Palsson <karlp@etactica.com>
Maintainer: @karlp
Fix compilation problems by backporting two upstream commits. Patches fix the glibc detection related compilation problems (and random number generation with glibc and without TLS).
Reference to issue #9005
Compile tested: ipq806x/R7800, OpenWrt master
Run tested: -
Karl, any objections for applying the upstream glibc related fix that you seemed to acknowledge a month ago in #9005 ? Mosquitto has been broken in buildbot for a month, now. I noticed this in the collectd version update discussion, so I though to fix it to enable proper compilation of all collectd modules.
References:
bug report #9005
Upstream discussion:
eclipse/mosquitto#1291
Upstream commits:
eclipse/mosquitto@d05bd95
eclipse/mosquitto@b1298df