bird1: fix out of memory error when parsing /etc/config/bird{4,6} /etc/init.d/bird{4,6} start #921
Conversation
|
It is very important for our Community Guifi.Net xarbot |
|
@rogerpueyo please restart the pipeline. |
rogerpueyo
force-pushed
the
master-fix-920
branch
from
aa7a3ab
to
b8dd869
Compare
|
Hi, @mwarning, The pipeline will still fail, even if the packages are actually built. I submitted PR #928 which merges the two Makefiles (for IPv4 and IPv6, each in its respective folder) into a single Makefile. After that, the pipeline checks shall succeed. Would you please consider merging #928 first? Thanks for taking care of the PR! PS: the failing check on PR #928 seems to be related to |
|
Hello. What's the current status for this PR? Since PR #928 is already merged, restarting the pipelines might fix the compile errors @rogerpueyo |
|
Hi, @p4u, Thanks for bumping this. PR #928 is not yet merged. We should get that one merged first. Unfortunately, there's one single architecture for which the tests don't pass (powerpc_8540), which is blocking #928 from being merged. I believe it is not caused by the commit itself. |
rogerpueyo
force-pushed
the
master-fix-920
branch
from
b8dd869
to
9e783a3
Compare
|
@PolynomialDivision merge this, please and backport this to stable branches |
This patch renames the get_bool() function, implemented in the bird4-lib.sh and bird6-lib.sh files (respectively, for the IPv4 and the IPv6 versions of the package), as well as all the calls to it. This way, we avoid a function name collision with the one provided by file /lib/functions.sh, which is slightly different and caused an out-of-memory error when parsing the bird4/bird6 UCI config files. Fixes openwrt#920. Signed-off-by: Roger Pueyo Centelles <roger.pueyo@guifi.net>
Maintainer: @rogerpueyo
Compile tested: x86_64 VirtualBox VM, OpenWrt snapshot 2022/11/16
Run tested: x86_64 VirtualBox VM, OpenWrt snapshot 2022/11/16
Description: the bird4-lib.sh and bird6-lib.sh implement a get_bool() function that collides with the one provided by /lib/functions.sh.
This patch renames the get_bool() functions implemented in the init.d helper files bird4-lib.sh and bird6-lib.sh to get_a_bool(), as well as all the calls to them. This way, we avoid colliding with the get_bool() function provided by /lib/functions.sh, which caused an out-of-memory error when parsing the UCI-based bird4/bird6 config.
Fixes #920.
Signed-off-by: Roger Pueyo Centelles roger.pueyo@guifi.net