Fix has_better_load evaluation #7
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes two bugs: 1) if condition in is_better_candidate previously always evaluated to false. 2) below_load_threshold actually implemented above_load_threshold Signed-off-by: Daniel Albers <daniel@lbe.rs>
|
Closing in favor of https://lists.openwrt.org/pipermail/openwrt-devel/2024-May/042784.html. |
|
This repo has not received any updates in a year. Is this still being developed? I believe Usteer has very good potential, but the lack of updates is very unfortunate. |
|
Yeah, no idea. https://github.com/openwrt/usteer?tab=readme-ov-file#submitting-patches said to send patches via the mailing list, but no response there either. IRC is responsive, but nobody there seems to feel responsible for usteer either. Maybe @blocktrron could comment? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes two bugs:
Fixes #5