Simplified Enabler UI #92
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le Service is not running.
|
This looks great, thanks Nick. I've merged and push to the branch 'simplified-enabler' because I want to see if you could add one more thing. When you have a data source enabled but not connected, I'd like the icon to still show up on the main activity but in red. For example, if I have a network data source enabled but it can't connect, I should see the network source icon in red. |
|
Actually I'll merge this into next in the meantime, the red icons can be an enhancement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main UI on the enabler has been compressed to show only the following:
A warning iff the VehicleManager service is not running and bound to the application.
A section showing an icon for which type(s) of connections are active, e.g.: USB, Bluetooth, Trace File, Network, Unknown.
The number of messages received.