Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove torch strict symbolic shape setup passes. #17348

Open
stellaraccident opened this issue May 10, 2024 · 0 comments
Open

Remove torch strict symbolic shape setup passes. #17348

stellaraccident opened this issue May 10, 2024 · 0 comments
Assignees

Comments

@stellaraccident
Copy link
Collaborator

As of llvm/torch-mlir#3319, upstream now sets the strict attribute on functions produced via fx/dynamo, so we don't have to do it locally. The following can be removed (and all impl/support): https://github.com/iree-org/iree/blob/main/compiler/plugins/input/Torch/InputConversion/Passes.cpp#L40

To account for any IR in the wild, maybe plan to drop this in ~July 2024.

@stellaraccident stellaraccident self-assigned this May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant