Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Builds on Windows #19

Closed
stellaraccident opened this issue Oct 13, 2019 · 2 comments
Closed

Support Builds on Windows #19

stellaraccident opened this issue Oct 13, 2019 · 2 comments
Labels
infrastructure Relating to build systems, CI, or testing platform/windows 🚪 Windows-specific build, execution, benchmarking, and deployment
Projects
Infrastructure and Benchmarking

Comments

@stellaraccident
Copy link
Collaborator

We ultimately want to support Windows builds via cmake and bazel. This issue will track the progress.

With a bit of tweaking, the bazel build mostly works for:
iree/tools/run_module (the simplest e2e example)
stellaraccident pushed a commit that referenced this issue Oct 13, 2019
Basic support for building on windows.
4c3479e 
* Requires clang-cl
* Spews a bunch of warning about benign redefinitions and unknown
command line arguments (needs triage).
* Allows building of iree/tools/run_module and iree/tools/iree-run-mlir,
which together, account for building most of the non-test assets.

#19
stellaraccident pushed a commit that referenced this issue Oct 13, 2019
Basic support for building on windows.
72ee616 
* Requires clang-cl
* Spews a bunch of warning about benign redefinitions and unknown
command line arguments (needs triage).
* Allows building of iree/tools/run_module and iree/tools/iree-run-mlir,
which together, account for building most of the non-test assets.

#19

Convert to unix line endings (why, windows, why).
stellaraccident pushed a commit that referenced this issue Oct 13, 2019
Basic support for building on windows.
c82229d 
* Requires clang-cl
* Spews a bunch of warning about benign redefinitions and unknown
command line arguments (needs triage).
* Allows building of iree/tools/run_module and iree/tools/iree-run-mlir,
which together, account for building most of the non-test assets.

#19
@stellaraccident stellaraccident mentioned this issue Oct 13, 2019
Merged
stellaraccident pushed a commit that referenced this issue Oct 13, 2019
Fix path issue in lit test runner so it works on Windows under msys2.
386f3e2 
With this, all of the iree/compiler/... tests build/pass.

#19
stellaraccident pushed a commit that referenced this issue Oct 13, 2019
Fix argument command line parsing to trim options.
0bf8e99 
This has the side effect of getting most compiler and e2e tests running
on Windows, although some are failing (for unknown reasons).

Closes #23
#19
@stellaraccident
Copy link
Collaborator Author

With PR22, I've mostly got things building and testing on Windows. There are some e2e tests that appear to be failing on some mysterious FileCheck pipeline issue that is not immediately obvious (and has he smell of something subtly Windows specific).

I'll write a doc on how to setup your Windows build environment.

stellaraccident pushed a commit that referenced this issue Oct 13, 2019
Basic support for building on windows. (#22)
c7016b1 
* Basic support for building on windows.

* Requires clang-cl
* Spews a bunch of warning about benign redefinitions and unknown
command line arguments (needs triage).
* Allows building of iree/tools/run_module and iree/tools/iree-run-mlir,
which together, account for building most of the non-test assets.

#19

* Fix path issue in lit test runner so it works on Windows under msys2.

With this, all of the iree/compiler/... tests build/pass.

#19

* Filter for the lit RUN line (not just first line).

This allows the e2e tests that include comments first to function.

I really need to get lit working properly but this gets us to the point
where all of the compiler and e2e tests work (on Windows too).

* Make the lit RUN line matching more robust.

* Fix argument command line parsing to trim options.

This has the side effect of getting most compiler and e2e tests running
on Windows, although some are failing (for unknown reasons).

Closes #23
#19
stellaraccident pushed a commit to stellaraccident/iree that referenced this issue Oct 14, 2019
Basic support for building on windows.
adcd66a 
* Requires clang-cl
* Spews a bunch of warning about benign redefinitions and unknown
command line arguments (needs triage).
* Allows building of iree/tools/run_module and iree/tools/iree-run-mlir,
which together, account for building most of the non-test assets.

iree-org#19

Fix path issue in lit test runner so it works on Windows under msys2.

With this, all of the iree/compiler/... tests build/pass.

iree-org#19

Filter for the lit RUN line (not just first line).

This allows the e2e tests that include comments first to function.

I really need to get lit working properly but this gets us to the point
where all of the compiler and e2e tests work (on Windows too).

Make the lit RUN line matching more robust.

Fix argument command line parsing to trim options.

This has the side effect of getting most compiler and e2e tests running
on Windows, although some are failing (for unknown reasons).

Closes iree-org#23
iree-org#19

Edit positional command arguments in place.
@stellaraccident stellaraccident mentioned this issue Oct 14, 2019
Closed
stellaraccident pushed a commit to stellaraccident/iree that referenced this issue Oct 14, 2019
Basic support for building on windows.
d94b043 
* Requires clang-cl
* Spews a bunch of warning about benign redefinitions and unknown
command line arguments (needs triage).
* Allows building of iree/tools/run_module and iree/tools/iree-run-mlir,
which together, account for building most of the non-test assets.

iree-org#19

Fix path issue in lit test runner so it works on Windows under msys2.

With this, all of the iree/compiler/... tests build/pass.

iree-org#19

Filter for the lit RUN line (not just first line).

This allows the e2e tests that include comments first to function.

I really need to get lit working properly but this gets us to the point
where all of the compiler and e2e tests work (on Windows too).

Make the lit RUN line matching more robust.

Fix argument command line parsing to trim options.

This has the side effect of getting most compiler and e2e tests running
on Windows, although some are failing (for unknown reasons).

Closes iree-org#23
iree-org#19

Edit positional command arguments in place.
stellaraccident added a commit that referenced this issue Oct 14, 2019
@stellaraccident
Basic support for building on windows.
aa854a1 
* Requires clang-cl
* Spews a bunch of warning about benign redefinitions and unknown
command line arguments (needs triage).
* Allows building of iree/tools/run_module and iree/tools/iree-run-mlir,
which together, account for building most of the non-test assets.

#19

Fix path issue in lit test runner so it works on Windows under msys2.

With this, all of the iree/compiler/... tests build/pass.

#19

Filter for the lit RUN line (not just first line).

This allows the e2e tests that include comments first to function.

I really need to get lit working properly but this gets us to the point
where all of the compiler and e2e tests work (on Windows too).

Make the lit RUN line matching more robust.

Fix argument command line parsing to trim options.

This has the side effect of getting most compiler and e2e tests running
on Windows, although some are failing (for unknown reasons).

Closes #23
#19

Edit positional command arguments in place.

Closes #56

COPYBARA_INTEGRATE_REVIEW=#56 from stellaraccident:winbuild d94b043
PiperOrigin-RevId: 274613114
ScottTodd added a commit that referenced this issue Dec 9, 2019
@ScottTodd
Get SDL2, ImGui, and graphics sample building on Windows with Bazel.
412b242 
* Fix Vulkan SDK lib path on Windows.
* Workaround SDL omitting includes for intrinsics.
* Adjust .bazelrc to be less restrictive (Windows GDI, Graphics Device Interace, is needed now).

Relates to #19
@ScottTodd ScottTodd mentioned this issue Dec 9, 2019
Closed
ScottTodd added a commit that referenced this issue Dec 11, 2019
@ScottTodd
Get SDL2, ImGui, and graphics sample building on Windows with Bazel.
31e9e66 
* Fix Vulkan SDK lib path on Windows.
* Workaround SDL omitting includes for intrinsics.
* Adjust .bazelrc to be less restrictive (Windows GDI, Graphics Device Interace, is needed now).

Relates to #19
iree-copybara-bot pushed a commit that referenced this issue Dec 11, 2019
@ScottTodd @iree-copybara-bot
Get SDL2, ImGui, and graphics sample building on Windows with Bazel.
6a7959a 
* Fix Vulkan SDK lib path on Windows.
* Workaround SDL omitting includes for intrinsics.
* Adjust .bazelrc to be less restrictive (Windows GDI, Graphics Device Interace, is needed now).

Tested that `bazel build //...` and ` bazel run //iree/samples/rt/vulkan:vk_graphics_integration` both work on my Windows machine.

Relates to #19

Closes #180

COPYBARA_INTEGRATE_REVIEW=#180 from google:scotttodd-windows-sdl 607f30b
PiperOrigin-RevId: 284996490
@benvanik benvanik added the infrastructure Relating to build systems, CI, or testing label Mar 19, 2020
@ScottTodd ScottTodd added the platform/windows 🚪 Windows-specific build, execution, benchmarking, and deployment label Mar 24, 2020
@ScottTodd
Copy link
Collaborator

I think we can close this issue for now, since most core targets build and run on Windows now, and track specific missing pieces separately.

Infrastructure and Benchmarking automation moved this from In progress to Done Mar 24, 2020
@GMNGeoffrey GMNGeoffrey mentioned this issue Mar 29, 2023
Merged
@monorimet monorimet mentioned this issue Aug 3, 2023
Closed
@dpackwood dpackwood mentioned this issue Sep 8, 2023
Closed
stellaraccident pushed a commit that referenced this issue Sep 24, 2023
Fix sync.py for relative paths and old clones. (#19)
2ee66e0 
* Reportedly some older envs/python versions can return a relative path
for __file__, which can make the parent traversal dodgy. Makes sure it
is absolute.
* If just updating a repo to a new commit, was not fetching, so the
checkout would fail if too old.
@gabeweisz gabeweisz mentioned this issue Mar 25, 2024
Open
@LLITCHEV LLITCHEV mentioned this issue Mar 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
infrastructure Relating to build systems, CI, or testing platform/windows 🚪 Windows-specific build, execution, benchmarking, and deployment
Projects
No open projects
Infrastructure and Benchmarking
  
Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@benvanik @stellaraccident @ScottTodd