Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not run buildAndTest GitHub Action if only markdown changes #110

Closed
GleasonK opened this issue Sep 12, 2022 · 1 comment · Fixed by #113
Closed

Do not run buildAndTest GitHub Action if only markdown changes #110

GleasonK opened this issue Sep 12, 2022 · 1 comment · Fixed by #113
Assignees
@GleasonK
Labels
Build

Comments

@GleasonK
Copy link
Member

Request description

We should only run build and test if there is a source change, the definition of source change can become more precise over time, but "not markdown" should resolve this issue for the majority of PRs that have come through (spec changes).

I noticed that #109 triggered a build of the StableHLO source code, when it was a simple markdown fix.
@GleasonK GleasonK self-assigned this Sep 12, 2022
@GleasonK
Copy link
Member Author

Can be resolved with adding paths-ignore to the action.

on:
  push:
    branches:
      - main
    paths-ignore:
      - '**.md'

@GleasonK GleasonK mentioned this issue Sep 12, 2022
Merged
GleasonK added a commit that referenced this issue Sep 12, 2022
@GleasonK
Don't run Build and Test Action if only doc or readme changes. (#113)
6a06657 
Don't run buildAndTest for doc / markdown updates. Closes #110.
@burmako burmako added Build and removed Process labels Nov 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GleasonK GleasonK

Labels
Build
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't run Build and Test Action if only doc or readme changes. GleasonK/stablehlo
2 participants
@burmako @GleasonK