Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix constraints for TransposeOp #1345

Merged
merged 1 commit into from
Mar 22, 2023
Merged

Fix constraints for TransposeOp #1345

merged 1 commit into from
Mar 22, 2023

Conversation

sdasgup3
Copy link
Member

@sdasgup3 sdasgup3 commented Mar 22, 2023 •
edited
Loading

Fixes the type constraint (C3) of transpose op.

fixes #1339. Please refer to the same ticket for more details.

Note that the implementation of the (C3) is still correct

stablehlo/stablehlo/dialect/TypeInference.cpp

Line 2898 in 076c6ab

resultShape.push_back(inputShape[dim]);

@anakinxc

@sdasgup3 sdasgup3 added the Spec label Mar 22, 2023
@sdasgup3 sdasgup3 requested a review from burmako March 22, 2023 15:42
@burmako burmako changed the title fix the spc for transpose op Fix constraints for TransposeOp Mar 22, 2023
@burmako burmako assigned sdasgup3 and unassigned burmako Mar 22, 2023
@sdasgup3 sdasgup3 mentioned this pull request Mar 22, 2023
Closed
@burmako burmako merged commit d2e64e4 into openxla:main Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@burmako burmako burmako approved these changes

Assignees

@sdasgup3 sdasgup3

Labels
Spec
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inconsistent permutation spec between xla transpose and stablehlo::TransposeOp
2 participants
@sdasgup3 @burmako