Add Float8E4M3B11FNUZ type support. #1448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GleasonK
approved these changes
May 1, 2023
There was a problem hiding this comment.
This LGTM, two test case comments. Also now that I'm seeing that the type changes are in Base.td, the MHLO integration work may be taken care of already. Any negative test case changes (update expected error message), will be taken care of by the StableHLO oncall.
Will let @ghpvnist review the spec.md and reference/ changes.
|
Also regarding the merge conflict, you can overwrite with your changes to |
ghpvnist
approved these changes
May 2, 2023
GleasonK
reviewed
May 2, 2023
As proposed in [RFC: E4M3B11FNUZ in XLA](https://github.com/openxla/stablehlo/blob/main/rfcs/20230309-e4m3b11.md) (openxla#1308), this change adds support for this type to StableHLO. This includes the type definitions, vhlo, and interpreter support. The testing approach mirrors the Float8E4M3FNUZ tests, since it is also a "non-standard" floating point type supported by StableHLO.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As proposed in RFC: E4M3B11FNUZ in XLA (#1308), this change adds support for these types to StableHLO.
This includes the type definitions, vhlo, and interpreter support. The testing approach mirrors the Float8E4M3FNUZ tests, since it is also a "non-standard" floating point type supported by StableHLO.