[XLA:CPU] Enable BMM+Mul+Add for bf16 #11241
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
penpornk
suggested changes
May 7, 2024
Comment on lines
387
to
392
| if (!IsBatchDot(*dot_instr)) { | ||
| if (!IsRowMajor(lhs_shape) || !IsRowMajor(rhs_shape) || | ||
| !IsRowMajor(output_shape)) { | ||
| return false; | ||
| } | ||
| } |
There was a problem hiding this comment.
Nit: Let's avoid nested ifs. (Please apply code formatter.)
Suggested change
| if (!IsBatchDot(*dot_instr)) { | |
| if (!IsRowMajor(lhs_shape) || !IsRowMajor(rhs_shape) || | |
| !IsRowMajor(output_shape)) { | |
| return false; | |
| } | |
| } | |
| if (!IsBatchDot(*dot_instr) && | |
| (!IsRowMajor(lhs_shape) || !IsRowMajor(rhs_shape) || | |
| !IsRowMajor(output_shape))) { | |
| return false; | |
| } |
There was a problem hiding this comment.
@penpornk I made the requested change. Thanks!
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
May 8, 2024
Imported from GitHub PR openxla/xla#11241 This PR enable BatchMatmul + Mul + Add fusion for BF16 and also fixes a bug for the same. Copybara import of the project: -- abdbf9b89925c8553296122c846327b6dffa86ce by Kanvi Khanna <kanvi.khanna@intel.com>: Enable BMM+Mul+Add for bf16 -- 6674ac76b868f0399731d6185287eec76244df3a by Kanvi Khanna <kanvi.khanna@intel.com>: fix test -- 8fb80082e8c545e007ab7a2d363eb7b7c251fd07 by Kanvi Khanna <kanvi.khanna@intel.com>: address review comment, fix test, format Merging this change closes #11241 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#11241 from Intel-tensorflow:kanvi/bmm-mul-add_bf16 8fb80082e8c545e007ab7a2d363eb7b7c251fd07 PiperOrigin-RevId: 631717784
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
May 8, 2024
Imported from GitHub PR openxla/xla#11241 This PR enable BatchMatmul + Mul + Add fusion for BF16 and also fixes a bug for the same. Copybara import of the project: -- abdbf9b89925c8553296122c846327b6dffa86ce by Kanvi Khanna <kanvi.khanna@intel.com>: Enable BMM+Mul+Add for bf16 -- 6674ac76b868f0399731d6185287eec76244df3a by Kanvi Khanna <kanvi.khanna@intel.com>: fix test -- 8fb80082e8c545e007ab7a2d363eb7b7c251fd07 by Kanvi Khanna <kanvi.khanna@intel.com>: address review comment, fix test, format Merging this change closes #11241 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#11241 from Intel-tensorflow:kanvi/bmm-mul-add_bf16 8fb80082e8c545e007ab7a2d363eb7b7c251fd07 PiperOrigin-RevId: 631717784
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
May 8, 2024
FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#11241 from Intel-tensorflow:kanvi/bmm-mul-add_bf16 8fb80082e8c545e007ab7a2d363eb7b7c251fd07 PiperOrigin-RevId: 631306324
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
May 8, 2024
Updates LLVM usage to match [aefad851672e](llvm/llvm-project@aefad851672e) FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#11241 from Intel-tensorflow:kanvi/bmm-mul-add_bf16 8fb80082e8c545e007ab7a2d363eb7b7c251fd07 PiperOrigin-RevId: 631745757
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
May 8, 2024
Imported from GitHub PR openxla/xla#11241 This PR enable BatchMatmul + Mul + Add fusion for BF16 and also fixes a bug for the same. Copybara import of the project: -- abdbf9b89925c8553296122c846327b6dffa86ce by Kanvi Khanna <kanvi.khanna@intel.com>: Enable BMM+Mul+Add for bf16 -- 6674ac76b868f0399731d6185287eec76244df3a by Kanvi Khanna <kanvi.khanna@intel.com>: fix test -- 8fb80082e8c545e007ab7a2d363eb7b7c251fd07 by Kanvi Khanna <kanvi.khanna@intel.com>: address review comment, fix test, format Merging this change closes #11241 PiperOrigin-RevId: 631745536
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enable BatchMatmul + Mul + Add fusion for BF16 and also fixes a bug for the same.