[ROCm] Build fixes #11458
Closed
[ROCm] Build fixes #11458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How do you test this build locally? I've seen a couple of such fix-style PRs already. |
golechwierowicz
approved these changes
Apr 12, 2024
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Apr 12, 2024
Imported from GitHub PR openxla/xla#11458 Contains fix for compile failure after e21311e52a0be80042d4c807847ec17919f2f954 Contains fix for link failure after 596745eca6b9fb1553ee71b63c71e92527f1d7f4 Copybara import of the project: -- b253cbac2da4515ff4437b820f37a2b097a287c1 by Dragan Mladjenovic <Dragan.Mladjenovic@amd.com>: [ROCm] Build fixes Contains fix for compile failure after e21311e52a0be80042d4c807847ec17919f2f954 Contains fix for link failure after 596745eca6b9fb1553ee71b63c71e92527f1d7f4 Merging this change closes #11458 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#11458 from ROCm:build_fix_11042024 b253cbac2da4515ff4437b820f37a2b097a287c1 PiperOrigin-RevId: 624087353
|
I guess you would need an docker container with rocm such as https://hub.docker.com/r/rocm/tensorflow-build/tags. I think just building hlo-opt or hlo_runner_main for --config=rocm should be enough to trigger failure like this. |
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Apr 12, 2024
Imported from GitHub PR openxla/xla#11458 Contains fix for compile failure after e21311e52a0be80042d4c807847ec17919f2f954 Contains fix for link failure after 596745eca6b9fb1553ee71b63c71e92527f1d7f4 Copybara import of the project: -- b253cbac2da4515ff4437b820f37a2b097a287c1 by Dragan Mladjenovic <Dragan.Mladjenovic@amd.com>: [ROCm] Build fixes Contains fix for compile failure after e21311e52a0be80042d4c807847ec17919f2f954 Contains fix for link failure after 596745eca6b9fb1553ee71b63c71e92527f1d7f4 Merging this change closes #11458 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#11458 from ROCm:build_fix_11042024 b253cbac2da4515ff4437b820f37a2b097a287c1 PiperOrigin-RevId: 624087353
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Apr 12, 2024
FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#11458 from ROCm:build_fix_11042024 b253cbac2da4515ff4437b820f37a2b097a287c1 PiperOrigin-RevId: 624098040
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Apr 12, 2024
FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#11458 from ROCm:build_fix_11042024 b253cbac2da4515ff4437b820f37a2b097a287c1 PiperOrigin-RevId: 624086154
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Apr 12, 2024
FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#11458 from ROCm:build_fix_11042024 b253cbac2da4515ff4437b820f37a2b097a287c1 PiperOrigin-RevId: 623347808
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Apr 12, 2024
Imported from GitHub PR openxla/xla#11458 Contains fix for compile failure after e21311e52a0be80042d4c807847ec17919f2f954 Contains fix for link failure after 596745eca6b9fb1553ee71b63c71e92527f1d7f4 Copybara import of the project: -- b253cbac2da4515ff4437b820f37a2b097a287c1 by Dragan Mladjenovic <Dragan.Mladjenovic@amd.com>: [ROCm] Build fixes Contains fix for compile failure after e21311e52a0be80042d4c807847ec17919f2f954 Contains fix for link failure after 596745eca6b9fb1553ee71b63c71e92527f1d7f4 Merging this change closes #11458 PiperOrigin-RevId: 624120147
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Apr 12, 2024
FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#11458 from ROCm:build_fix_11042024 b253cbac2da4515ff4437b820f37a2b097a287c1 PiperOrigin-RevId: 624128857
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains fix for compile failure after e21311e
Contains fix for link failure after 596745e