[GPU] Fix handling of flags in the cuDNN FMHA test. #12224
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasjoerg
requested changes
May 8, 2024
| @@ -91,7 +89,7 @@ class MultiHeadedAttentionTest : public GpuCodegenTest { | |||
| DebugOptions GetDebugOptionsForTest() override { | |||
| auto debug_options = HloTestBase::GetDebugOptionsForTest(); | |||
| debug_options.set_xla_gpu_enable_xla_runtime_executable(false); | |||
| debug_options.set_xla_gpu_enable_cudnn_fmha(false); | |||
| debug_options.set_xla_gpu_enable_cudnn_fmha(true); | |||
There was a problem hiding this comment.
Nit: The code below would be more concise and easier to read if you just pass the bool config_with_fmha into this function.
There was a problem hiding this comment.
This function is an override, it does not accept parameters. Functions like ParseAndReturnVerifiedModule apply debug options set by GetDebugOptionsForTest automatically. You are right though, code can be simplified further, I did that.
thomasjoerg
approved these changes
May 8, 2024
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
May 8, 2024
Imported from GitHub PR openxla/xla#12224 The test got broken by openxla/xla@8799ff0, this commit fixes it. Copybara import of the project: -- 80528497321ee6020126b15035050f4c1a0beea9 by Ilia Sergachev <isergachev@nvidia.com>: [GPU] Fix handling of flags in the cuDNN FMHA test. Merging this change closes #12224 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#12224 from openxla:fix_fmha_test 80528497321ee6020126b15035050f4c1a0beea9 PiperOrigin-RevId: 631728934
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
May 8, 2024
Imported from GitHub PR openxla/xla#12224 The test got broken by openxla/xla@8799ff0, this commit fixes it. Copybara import of the project: -- 80528497321ee6020126b15035050f4c1a0beea9 by Ilia Sergachev <isergachev@nvidia.com>: [GPU] Fix handling of flags in the cuDNN FMHA test. Merging this change closes #12224 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#12224 from openxla:fix_fmha_test 80528497321ee6020126b15035050f4c1a0beea9 PiperOrigin-RevId: 631728934
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
May 8, 2024
Imported from GitHub PR openxla/xla#12224 The test got broken by openxla/xla@8799ff0, this commit fixes it. Copybara import of the project: -- 80528497321ee6020126b15035050f4c1a0beea9 by Ilia Sergachev <isergachev@nvidia.com>: [GPU] Fix handling of flags in the cuDNN FMHA test. Merging this change closes #12224 PiperOrigin-RevId: 631744108
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test got broken by 8799ff0, this commit fixes it.