[XLA:GPU] Fix compute time calculation in the performance model. #13044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
copybara-service
bot
force-pushed
the
test_632531510
branch
from
402a8c2
to
c834bd4
Compare
copybara-service
bot
force-pushed
the
test_632531510
branch
2 times, most recently
from
d73b191
to
cfb08fe
Compare
The compute time should be calculated based on the number of active cores, which is the minimum of the number of blocks and the number of cores on the device. Originally suggested in #12208. Co-authored-by: lingzhi98 <lingzhi.zhou@intel.com> PiperOrigin-RevId: 638183155
copybara-service
bot
force-pushed
the
test_632531510
branch
from
cfb08fe
to
4667359
Compare
copybara-service
bot
closed this pull request by merging all changes
into
main
in
4667359
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[XLA:GPU] Fix compute time calculation in the performance model.
The compute time should be calculated based on the number of active cores, which is the minimum of the number of blocks and the number of cores on the device.
Originally suggested in #12208.
Co-authored-by: lingzhi98 lingzhi.zhou@intel.com