[Draft][XLA:GPU] Add sycl runtime #9042

ShengYang1 · 2024-02-01T06:52:02Z

This PR aims to add sycl runtime support, we can run basic JAX GPU UTs with it. It includes:

sycl runtime crosstool build
sycl stream executor
spirv-llvm-translator
registration of spir_compiler/computation placer/transfer manager
refine build file to remove cuda specific changes(especially those cuda kernels)
fix CudaCubin to load spirv binary
fix metadata

This is a draft PR to show what is needed to run JAX on sycl runtime.

Zantares · 2024-02-01T08:56:31Z

Hi @penpornk , this is the big SYCL runtime PR for preview and CI test, we will continue to split it into small PRs.

Next work:

Split this PR into small PRs. Any suggestions or review comments are welcome

We still need some JAX work to enable Intel public CI for this PR. Will share CI result to this PR after it's done

xla/stream_executor/cuda/cuda_executor.cc

penpornk

Thank you for the PR! Could you please help make it buildable when SYCL is not configured? (All presubmit CIs are failing. I'm not sure why all their error logs aren't viewable though.)

The Intel Extension for OpenXLA plug-in requires oneAPI Base Toolkit installation for DPC++, oneMKL, and oneTBB. I don't see their headers in this PR. Does this mean we can build this PR with SYCL without installing the oneAPI Base Toolkit?

xla/pjrt/pjrt_compiler.h

xla/service/gpu/llvm_gpu_backend/gpu_backend_lib.cc

penpornk · 2024-02-08T09:46:06Z

xla/stream_executor/sycl/sycl_driver.cc

+#include "xla/stream_executor/platform/port.h"
+#include "xla/stream_executor/sycl/sycl_gpu_runtime.h"
+
+#include <level_zero/ze_api.h>


Does the user need to install Level Zero driver (intel-level-zero-gpu and level-zero) to build this file, or is the headers package (level-zero-dev) enough?

level-zero-dev is enough for building.

ShengYang1 · 2024-02-18T06:50:00Z

Thank you for the PR! Could you please help make it buildable when SYCL is not configured? (All presubmit CIs are failing. I'm not sure why all their error logs aren't viewable though.)

Sorry for the late reply. I have rebased the code and now it should work.

The Intel Extension for OpenXLA plug-in requires oneAPI Base Toolkit installation for DPC++, oneMKL, and oneTBB. I don't see their headers in this PR. Does this mean we can build this PR with SYCL without installing the oneAPI Base Toolkit?

oneAPI Base Toolkit is needed for the headers, for example sycl.hpp is included here.

Imported from GitHub PR openxla/xla#10244 It is a sub PR of openxla/xla#9042. Then we can build xla with sycl support like: `bazel build --config=sycl xxx` Copybara import of the project: -- e1bc7ac90f3403a477ba14533dea972de6a2c262 by Sheng, Yang <yang.sheng@intel.com>: Add sycl build target Merging this change closes #10244 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#10244 from Intel-tensorflow:yang/syclbuild e1bc7ac90f3403a477ba14533dea972de6a2c262 PiperOrigin-RevId: 615176784

Imported from GitHub PR openxla/xla#10247 It is a sub PR of openxla/xla#9042. Copybara import of the project: -- c2f60c318aebfe4e64bf3becfd40d04949c50b41 by Sheng, Yang <yang.sheng@intel.com>: Add sycl name in se_gpu_pjrt_client Merging this change closes #10247 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#10247 from Intel-tensorflow:yang/pjrt c2f60c318aebfe4e64bf3becfd40d04949c50b41 PiperOrigin-RevId: 615176920

Imported from GitHub PR #10247 It is a sub PR of #9042. Copybara import of the project: -- c2f60c3 by Sheng, Yang <yang.sheng@intel.com>: Add sycl name in se_gpu_pjrt_client Merging this change closes #10247 COPYBARA_INTEGRATE_REVIEW=#10247 from Intel-tensorflow:yang/pjrt c2f60c3 PiperOrigin-RevId: 617141542

Imported from GitHub PR openxla/xla#10247 It is a sub PR of openxla/xla#9042. Copybara import of the project: -- c2f60c318aebfe4e64bf3becfd40d04949c50b41 by Sheng, Yang <yang.sheng@intel.com>: Add sycl name in se_gpu_pjrt_client Merging this change closes #10247 PiperOrigin-RevId: 617141542

Imported from GitHub PR openxla/xla#11425 It is a sub PR of openxla/xla#9042 to add sycl platform Copybara import of the project: -- 7d0c37057c673f784089ce961d24276a496d43bd by Sheng, Yang <yang.sheng@intel.com>: Add sycl platform -- 8d1196831a20f69ba8880d8549007358928f6be1 by Sheng, Yang <yang.sheng@intel.com>: Add comments back Merging this change closes #11425 Reverts f5ff233 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#11425 from Intel-tensorflow:yang/sycl-platform 8d1196831a20f69ba8880d8549007358928f6be1 PiperOrigin-RevId: 631712809

Imported from GitHub PR openxla/xla#11425 It is a sub PR of openxla/xla#9042 to add sycl platform Copybara import of the project: -- 7d0c37057c673f784089ce961d24276a496d43bd by Sheng, Yang <yang.sheng@intel.com>: Add sycl platform -- 8d1196831a20f69ba8880d8549007358928f6be1 by Sheng, Yang <yang.sheng@intel.com>: Add comments back Merging this change closes #11425 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#11425 from Intel-tensorflow:yang/sycl-platform 8d1196831a20f69ba8880d8549007358928f6be1 PiperOrigin-RevId: 631712809

Imported from GitHub PR openxla/xla#11425 It is a sub PR of openxla/xla#9042 to add sycl platform Copybara import of the project: -- 7d0c37057c673f784089ce961d24276a496d43bd by Sheng, Yang <yang.sheng@intel.com>: Add sycl platform -- 8d1196831a20f69ba8880d8549007358928f6be1 by Sheng, Yang <yang.sheng@intel.com>: Add comments back Merging this change closes #11425 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#11425 from Intel-tensorflow:yang/sycl-platform 8d1196831a20f69ba8880d8549007358928f6be1 PiperOrigin-RevId: 634288679

Imported from GitHub PR #11767 This is a sub PR of #9042, it adds a script to build xla with `--config=sycl`. Here is how to use: ```bash workspace=$1 xla_path=$workspace/xla cd $workspace git clone -b yang/ci https://github.com/Intel-tensorflow/xla xla bash $xla_path/build_tools/sycl/build.sh $workspace ``` Copybara import of the project: -- d811bba by Sheng, Yang <yang.sheng@intel.com>: Add SYCL build script -- 0c2500b by Sheng, Yang <yang.sheng@intel.com>: change path Merging this change closes #11767 FUTURE_COPYBARA_INTEGRATE_REVIEW=#11767 from Intel-tensorflow:yang/ci 0c2500b PiperOrigin-RevId: 634661773

Imported from GitHub PR openxla/xla#11767 This is a sub PR of openxla/xla#9042, it adds a script to build xla with `--config=sycl`. Here is how to use: ```bash workspace=$1 xla_path=$workspace/xla cd $workspace git clone -b yang/ci https://github.com/Intel-tensorflow/xla xla bash $xla_path/build_tools/sycl/build.sh $workspace ``` Copybara import of the project: -- d811bba1548f0c983da473a0940b1ea3d8b2c436 by Sheng, Yang <yang.sheng@intel.com>: Add SYCL build script -- 0c2500b703b73bc340ccc9e3817c7ce54cc8d718 by Sheng, Yang <yang.sheng@intel.com>: change path Merging this change closes #11767 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#11767 from Intel-tensorflow:yang/ci 0c2500b703b73bc340ccc9e3817c7ce54cc8d718 PiperOrigin-RevId: 634661773

Imported from GitHub PR #11767 This is a sub PR of #9042, it adds a script to build xla with `--config=sycl`. Here is how to use: ```bash workspace=$1 xla_path=$workspace/xla cd $workspace git clone -b yang/ci https://github.com/Intel-tensorflow/xla xla bash $xla_path/build_tools/sycl/build.sh $workspace ``` Copybara import of the project: -- d811bba by Sheng, Yang <yang.sheng@intel.com>: Add SYCL build script -- 0c2500b by Sheng, Yang <yang.sheng@intel.com>: change path Merging this change closes #11767 COPYBARA_INTEGRATE_REVIEW=#11767 from Intel-tensorflow:yang/ci 0c2500b PiperOrigin-RevId: 634676627

Imported from GitHub PR openxla/xla#11767 This is a sub PR of openxla/xla#9042, it adds a script to build xla with `--config=sycl`. Here is how to use: ```bash workspace=$1 xla_path=$workspace/xla cd $workspace git clone -b yang/ci https://github.com/Intel-tensorflow/xla xla bash $xla_path/build_tools/sycl/build.sh $workspace ``` Copybara import of the project: -- d811bba1548f0c983da473a0940b1ea3d8b2c436 by Sheng, Yang <yang.sheng@intel.com>: Add SYCL build script -- 0c2500b703b73bc340ccc9e3817c7ce54cc8d718 by Sheng, Yang <yang.sheng@intel.com>: change path Merging this change closes #11767 PiperOrigin-RevId: 634676627

Imported from GitHub PR openxla/xla#11425 It is a sub PR of openxla/xla#9042 to add sycl platform Copybara import of the project: -- 7d0c37057c673f784089ce961d24276a496d43bd by Sheng, Yang <yang.sheng@intel.com>: Add sycl platform -- 8d1196831a20f69ba8880d8549007358928f6be1 by Sheng, Yang <yang.sheng@intel.com>: Add comments back Merging this change closes #11425 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#11425 from Intel-tensorflow:yang/sycl-platform 8d1196831a20f69ba8880d8549007358928f6be1 PiperOrigin-RevId: 634288679

Imported from GitHub PR openxla/xla#11425 It is a sub PR of openxla/xla#9042 to add sycl platform Copybara import of the project: -- 7d0c37057c673f784089ce961d24276a496d43bd by Sheng, Yang <yang.sheng@intel.com>: Add sycl platform -- 8d1196831a20f69ba8880d8549007358928f6be1 by Sheng, Yang <yang.sheng@intel.com>: Add comments back Merging this change closes #11425 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#11425 from Intel-tensorflow:yang/sycl-platform 8d1196831a20f69ba8880d8549007358928f6be1 PiperOrigin-RevId: 640626910

github-actions bot added the kokoro:force-run Forces CI to rerun label Feb 1, 2024

github-actions bot assigned kamaljeeti and xla-rotation Feb 1, 2024

kokoro-team removed the kokoro:force-run Forces CI to rerun label Feb 1, 2024

ShengYang1 marked this pull request as draft February 1, 2024 06:54

Zantares mentioned this pull request Feb 1, 2024

[RFC] Intel GPU integration openxla/community#99

Merged

This was referenced Feb 1, 2024

Skip add metadata for SPIR target #9044

Closed

Add size for CudaCubinInMemory #9045

Closed

i-chaochen reviewed Feb 1, 2024

View reviewed changes

xla/stream_executor/cuda/cuda_executor.cc Show resolved Hide resolved

penpornk self-assigned this Feb 1, 2024

penpornk added the kokoro:force-run Forces CI to rerun label Feb 8, 2024

penpornk suggested changes Feb 8, 2024

View reviewed changes

Add sycl runtime

8b322f8

ShengYang1 force-pushed the yang/runtime branch from f15897e to 8b322f8 Compare February 18, 2024 06:39

kokoro-team removed the kokoro:force-run Forces CI to rerun label Feb 18, 2024

Fix cpu error

3478495

penpornk added the kokoro:force-run Forces CI to rerun label Feb 19, 2024

kokoro-team removed the kokoro:force-run Forces CI to rerun label Feb 19, 2024

Zantares mentioned this pull request Feb 23, 2024

Add dlpack support for XPU for JAX #9834

Closed

This was referenced Mar 5, 2024

Add sycl build target #10244

Closed

Add sycl name in se_gpu_pjrt_client #10247

Closed

copybara-service bot mentioned this pull request Mar 12, 2024

PR #10244: Add sycl build target tensorflow/tensorflow#63558

Closed

copybara-service bot mentioned this pull request Mar 15, 2024

PR #10247: Add sycl name in se_gpu_pjrt_client tensorflow/tensorflow#63799

Merged

This was referenced Apr 11, 2024

[XLA:GPU] Add SPIRV-LLVM-Translator and translation pass #11424

Open

[XLA:GPU] Add sycl platform #11425

Open

ShengYang1 mentioned this pull request Apr 23, 2024

Add SYCL build script #11767

Closed

copybara-service bot mentioned this pull request May 8, 2024

PR #11425: [XLA:GPU] Add sycl platform tensorflow/tensorflow#67156

Closed

copybara-service bot mentioned this pull request May 16, 2024

PR #11425: [XLA:GPU] Add sycl platform tensorflow/tensorflow#67728

Draft

copybara-service bot mentioned this pull request May 17, 2024

PR #11767: Add SYCL build script #12613

Merged

copybara-service bot mentioned this pull request May 17, 2024

PR #11767: Add SYCL build script tensorflow/tensorflow#67809

Merged

copybara-service bot mentioned this pull request Jun 6, 2024

PR #11425: [XLA:GPU] Add sycl platform tensorflow/tensorflow#69315

Draft

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Draft][XLA:GPU] Add sycl runtime #9042

[Draft][XLA:GPU] Add sycl runtime #9042

ShengYang1 commented Feb 1, 2024 •

edited

Zantares commented Feb 1, 2024 •

edited

penpornk left a comment

penpornk Feb 8, 2024

ShengYang1 Feb 18, 2024

ShengYang1 commented Feb 18, 2024 •

edited

[Draft][XLA:GPU] Add sycl runtime #9042

Are you sure you want to change the base?

[Draft][XLA:GPU] Add sycl runtime #9042

Conversation

ShengYang1 commented Feb 1, 2024 • edited

Zantares commented Feb 1, 2024 • edited

penpornk left a comment

Choose a reason for hiding this comment

penpornk Feb 8, 2024

Choose a reason for hiding this comment

ShengYang1 Feb 18, 2024

Choose a reason for hiding this comment

ShengYang1 commented Feb 18, 2024 • edited

ShengYang1 commented Feb 1, 2024 •

edited

Zantares commented Feb 1, 2024 •

edited

ShengYang1 commented Feb 18, 2024 •

edited